feat: update prompts and invalidate cache #1082
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
This PR adds functionality to update prompt versions and manage cache invalidation in the Langfuse Python SDK.
- Adds
update_prompt()method intest_updating_prompt.pyto modify prompt labels and verify cache updates - Implements prompt version update functionality through
PromptVersionClientandAsyncPromptVersionClientclasses - Introduces cache invalidation with
invalidate()method inPromptCacheto remove cached prompts by name - Verifies updated prompt values match expected labels after modification through test assertions
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
This PR adds functionality for updating prompt labels and managing cache invalidation in the Langfuse Python SDK. Here's a focused summary of the key changes:
- Added test in
/tests/test_updating_prompt.pyto verify prompt label updates and cache behavior - Test creates initial prompt, updates labels, and verifies fetched prompt reflects changes
- Several test coverage gaps identified around cache invalidation, error cases, and content verification
The test file reveals potential improvements needed:
- Direct cache invalidation verification missing
- No error case handling for invalid prompts/versions
- No validation of reserved 'latest' label handling
- No verification that original prompt content persists after updates
I've focused only on the most recent changes and avoided repeating points from previous reviews. Let me know if you would like me to elaborate on any specific aspect.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
langfuse/api/__init__.py
Outdated
There was a problem hiding this comment.
Running this should get rid of all the file diffs due to formatting
poetry run ruff format langfuse/api --config ruff.tomlThere was a problem hiding this comment.
Thx! do you have an idea where this error here might come from?
ImportError while importing test module '/Users/maximiliandeichmann/development/github.com/langfuse/langfuse-python/tests/test_updating_prompt.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../../.pyenv/versions/3.9.1/lib/python3.9/importlib/__init__.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
tests/test_updating_prompt.py:1: in <module>
from langfuse.client import Langfuse
langfuse/__init__.py:3: in <module>
from .client import Langfuse # noqa
langfuse/client.py:43: in <module>
from langfuse.api.resources.prompts.types import (
E ImportError: cannot import name 'Prompt_Chat' from 'langfuse.api.resources.prompts.types' (/Users/maximiliandeichmann/development/github.com/langfuse/langfuse-python/langfuse/api/resources/prompts/types/__init__.py)
Somehow this fern run changed a lot i think.
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
This PR adds functionality for updating prompt version labels and cache invalidation in the Langfuse Python SDK. Here's a focused summary of the latest changes:
- Added
PromptVersionClientandAsyncPromptVersionClientin/langfuse/api/resources/prompt_version/client.pyfor managing prompt version updates - Implemented PATCH endpoint for updating prompt version labels with proper error handling
- Added prompt version module to API resources and public interface in
__init__.pyfiles - Updated API reference documentation in
reference.mdto include new prompt version update functionality
Key implementation details:
- Proper error handling for various HTTP status codes (400, 401, 403, 404, 405)
- Consistent implementation of both sync and async clients
- Clear documentation of 'latest' label being reserved and managed by Langfuse
9 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
interface of js and python sdk are inconsistent
langfuse = Langfuse()
langfuse.update_prompt(
prompt_name="movie-critic",
prompt_version=1,
new_labels=["john", "doe"], # assign these labels to the prompt version
)langfuse = Langfuse();
await langfuse.updatePrompt({
name: "movie-critic",
version: 1,
newLabels: ["john", "doe"],
});
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
This PR updates parameter naming in the Python SDK's client interface for better consistency. Here's a focused summary of the recent changes:
- Renamed parameters in
update_promptmethod fromprompt_name/prompt_versiontoname/versioninlangfuse/client.pyfor API consistency - Updated version to 2.57.13a0 in both
version.pyandpyproject.tomlto reflect interface changes - Maintained same functionality while improving parameter naming alignment between Python and TypeScript SDKs
The changes focus on making the interface more consistent across SDKs while preserving the core functionality of updating prompt version labels and cache invalidation.
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
Based on the latest changes and previous reviews, here's a focused summary of the recent updates:
Added comprehensive error handling and API documentation for prompt version updates in the Langfuse Python SDK.
- Added detailed error handling for HTTP status codes (400-405) in
/langfuse/api/resources/prompt_version/client.py - Documented reserved 'latest' label management by Langfuse in API docstrings
- Added clear examples and parameter descriptions in
/langfuse/api/reference.mdfor prompt version updates - Implemented proper JSON decoding error handling with ApiError class
The changes focus on improving robustness and documentation while avoiding repetition of previously reviewed functionality.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
Based on the recent changes and avoiding repetition from previous reviews, here's a focused summary of the latest updates:
Updated import paths and test utilities in the Langfuse Python SDK for better organization.
- Refactored import paths from
langfuse.api.coretolangfuse.corein/langfuse/api/tests/utils/test_http_client.pyandtest_query_encoding.py - Maintained test coverage for query encoding functionality with nested dictionary structures
- Ensured HTTP client tests continue to verify proper request body handling for JSON, files and additional parameters
- Updated API reference documentation to reflect consistent parameter naming across endpoints
The changes focus on code organization and import path standardization while maintaining existing test coverage and functionality.
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
Based on the latest changes and previous reviews, I'll provide a focused summary of the most recent updates:
The changes focus on import path reorganization in test utilities for the Langfuse Python SDK.
- Updated import path from
langfuse.core.query_encodertolangfuse.api.core.query_encoderintest_query_encoding.py - Modified import paths in
test_http_client.pyto uselangfuse.api.coreinstead oflangfuse.core - Maintained existing test functionality and assertions while improving code organization
These changes are part of a broader refactoring effort to standardize the codebase structure, while ensuring all existing tests continue to validate core functionality correctly.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
Based on the latest changes and previous reviews, here's a focused summary of the recent updates:
Added new prompt version management functionality to the Langfuse Python SDK.
- Added
prompt_versionmodule to API initialization files in/langfuse/api/__init__.pyand/langfuse/api/resources/__init__.py - Created empty auto-generated initialization file for prompt version module in
/langfuse/api/resources/prompt_version/__init__.py - Added API reference documentation for prompt version endpoint in
/langfuse/api/reference.md - Updated version to 2.57.13a0 in both
version.pyandpyproject.tomlto reflect new alpha features
The changes focus on properly exposing and documenting the new prompt version functionality while maintaining consistent code organization.
11 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| expected_labels = sorted(["latest", "doe", "production", "john"]) | ||
| assert sorted(fetched_prompt.labels) == expected_labels | ||
| assert sorted(updated_prompt.labels) == expected_labels |
There was a problem hiding this comment.
logic: Test assumes 'production' label persists after update - verify this is intended behavior
…com/langfuse/langfuse-python into max/lfe-3587-update-prompt-versions
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
Based on the latest changes and previous reviews, here's a focused summary of the recent updates:
Added cache invalidation functionality to the Langfuse Python SDK's prompt management system.
- Added
invalidate()method in/langfuse/prompt_cache.pyto remove cached prompts by name - Integrated cache invalidation with prompt version updates in
Langfuseclient - Updated test file
/tests/test_updating_prompt.pyto verify prompt updates and cache behavior - Ensured 'production' and 'latest' labels are properly handled in prompt version updates
The changes focus on robust cache management while maintaining data consistency during prompt version updates.
11 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
Based on the latest changes and previous reviews, here's a focused summary of the recent updates:
Simplified type handling and API endpoint paths in the Langfuse Python SDK.
- Updated API endpoint path from
/version/to/versions/inlangfuse/api/resources/prompt_version/client.pyfor consistency - Simplified
trace_tagstype annotation inScoreClientfrom nested sequence toUnion[str, Sequence[str]] - Removed unnecessary
jsonable_encodercall fortrace_tagsparameter in API requests - Updated example code to demonstrate simpler string-based tag usage
The changes focus on improving API consistency and simplifying type handling while maintaining core functionality.
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Curious, Will this work address the prompt not found issues I have been having? |
This feature addresses changes in labels without needing to create a new prompt version. We have until now been unsuccessful in reproducing the issue that you reported afaik. |
Oh boy. Let me double check my code to make sure its not an issue at my end cuz I am seeing it regularly. |
Important
Add
PromptVersionClientfor updating prompt versions and modifyLangfuseto support prompt updates and cache invalidation.PromptVersionClientinclient.pyto update prompt versions with new labels.Langfuseclass to includeupdate_prompt()method for updating prompt versions and invalidating cache.trace_tagsparameter inScoreClientto acceptstrorSequence[str].test_updating_prompt.pyto verify prompt update and cache invalidation.2.57.13a0inversion.pyandpyproject.toml.This description was created by
for bb9528e. It will automatically update as commits are pushed.