fix(langchain): invalid user_id / session_id in TraceBody (#956)

langfuse · Oct 7, 2024 · b404d6f · b404d6f
1 parent 1382618
commit b404d6f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 11 deletions.
diff --git a/langfuse/callback/langchain.py b/langfuse/callback/langchain.py
@@ -225,9 +225,13 @@ def on_chain_start(
             if parent_run_id is None and (tags or metadata):
                 self.trace_updates[run_id].update(
                     {
-                        "tags": tags and [str(tag) for tag in tags],
-                        "session_id": metadata and metadata.get("langfuse_session_id"),
-                        "user_id": metadata and metadata.get("langfuse_user_id"),
+                        "tags": [str(tag) for tag in tags] if tags else None,
+                        "session_id": metadata.get("langfuse_session_id")
+                        if metadata
+                        else None,
+                        "user_id": metadata.get("langfuse_user_id")
+                        if metadata
+                        else None,
                     }
                 )
 

diff --git a/tests/test_langchain.py b/tests/test_langchain.py
@@ -1960,8 +1960,6 @@ def test_link_langfuse_prompts_stream():
 def test_link_langfuse_prompts_batch():
     langfuse = Langfuse()
     trace_name = "test_link_langfuse_prompts_batch_" + create_uuid()[:8]
-    session_id = "session_" + create_uuid()[:8]
-    user_id = "user_" + create_uuid()[:8]
 
     # Create prompts
     joke_prompt_name = "joke_prompt_" + create_uuid()[:8]
@@ -2015,10 +2013,6 @@ def test_link_langfuse_prompts_batch():
             "callbacks": [langfuse_handler],
             "run_name": trace_name,
             "tags": ["langchain-tag"],
-            "metadata": {
-                "langfuse_session_id": session_id,
-                "langfuse_user_id": user_id,
-            },
         },
     )
 
@@ -2032,8 +2026,6 @@ def test_link_langfuse_prompts_batch():
         trace = get_api().trace.get(trace.id)
 
         assert trace.tags == ["langchain-tag"]
-        assert trace.session_id == session_id
-        assert trace.user_id == user_id
 
         observations = trace.observations