Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added llama 3.3 models #5497

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: added llama 3.3 models #5497

wants to merge 3 commits into from
+3 −0

Conversation

sujal011
Copy link

added new llama 3.3 models from groq

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 31, 2024
@sujal011 sujal011 changed the title added new llama 3.3 models feat: added support for llama 3.3 models Dec 31, 2024
@github-actions github-actions bot added the enhancement New feature or request label Dec 31, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 31, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #5497 will degrade performances by 10.34%

Comparing sujal011:main (8bfde98) with main (c55edcd)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main sujal011:main Change
⚡ test_load_flows 2.1 ms 1.1 ms +96.21%
❌ test_successful_run_with_input_type_any 277.5 ms 309.5 ms -10.34%
⚡ test_successful_run_with_output_type_any 342.8 ms 259.1 ms +32.33%

@sujal011
Copy link
Author

recheck

@sujal011 sujal011 changed the title feat: added support for llama 3.3 models feat: added llama 3.3 models Dec 31, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 31, 2024
ogabrielluiz
ogabrielluiz approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sujal011 !

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 2, 2025
@ogabrielluiz ogabrielluiz enabled auto-merge January 2, 2025 12:37
auto-merge was automatically disabled January 2, 2025 12:41

Head branch was pushed to by a user without write access

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 2, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 2, 2025
@sujal011
Copy link
Author

sujal011 commented Jan 2, 2025

@ogabrielluiz what is this codeflash error I have reported it as bug also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sujal011 @ogabrielluiz