Skip to content

Conversation

noeliecarbo
Copy link
Contributor

MistralAI (and embeddings in particular) is the only package that uses tenacity retries.

This PR removes them, offering the following benefits:

  • consistency with other packages
  • users can more easily customize retries according to their needs.

@github-actions github-actions bot added integration Related to a provider partner package integration feature labels Oct 15, 2025
Copy link

codspeed-hq bot commented Oct 15, 2025

CodSpeed Performance Report

Merging #33491 will not alter performance

Comparing noeliecarbo:noeliecarbo/feat_remove_tenacity_retries_from_mistralai_embeddings (7457d95) with master (6e25e18)

Summary

✅ 1 untouched
⏩ 33 skipped1

Footnotes

  1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Collaborator

@eyurtsev eyurtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noeliecarbo thanks for the contribution!

This is a breaking change, but it's not clear to me what users gain from it. What kind of customization would they want to do that's meaningful in practice from what they can already do?

@noeliecarbo
Copy link
Contributor Author

@noeliecarbo thanks for the contribution!

This is a breaking change, but it's not clear to me what users gain from it. What kind of customization would they want to do that's meaningful in practice from what they can already do?

@eyurtsev Thanks for the feedback! From my perspective, I see the following benefits:

  • For my use case, I need to catch specific HTTP 400 errors (too many inputs). It seems that the official MAX_TOKENS of the Mistral API is inaccurate and varies somewhat inexplicably.
  • Users may need different retry behaviors than those provided by retry_if_exception_type and wait_fixed (tenacity provides many more options).

@eyurtsev
Copy link
Collaborator

what happens if you set max_retries = 0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature integration Related to a provider partner package integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants