Skip to content

openai: cache httpx client #31260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 29, 2025
Merged

openai: cache httpx client #31260

merged 4 commits into from
May 29, 2025

Conversation

ccurme
Copy link
Collaborator

@ccurme ccurme commented May 16, 2025

Screenshot 2025-05-16 at 3 49 54 PM

@vercel Vercel
Copy link

vercel bot commented May 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview May 29, 2025 4:02pm

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 16, 2025
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label May 16, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 29, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #31260 will improve performances by ×98

Comparing cc/oai_cache_client (b87234f) with master (d9631ed)

Summary

⚡ 2 improvements
✅ 13 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ test_init_time 1,657.2 ms 16.9 ms ×98
⚡ test_init_time 1,657.1 ms 16.9 ms ×98

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 29, 2025 •
edited
Loading

CodSpeed Walltime Performance Report

Merging #31260 will not alter performance

Comparing cc/oai_cache_client (b87234f) with master (d9631ed)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

@ccurme ccurme merged commit afd349c into master May 29, 2025
57 checks passed
@ccurme ccurme deleted the cc/oai_cache_client branch May 29, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyurtsev eyurtsev eyurtsev approved these changes

Assignees
No one assigned
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccurme @eyurtsev @sydney-runkle