langchain_openai: Use convert_to_openai_messages internally in langchain-openai
#31226
+14
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:M
edwardzjl
force-pushed
the
lc-to-openai
branch
2 times, most recently
from
4fdf611 to
82ea63e
Compare
|
I noticed that langchain/libs/core/langchain_core/messages/utils.py Lines 1028 to 1029 in d4f77a8 However, langchain/libs/partners/openai/langchain_openai/chat_models/base.py Lines 228 to 229 in d4f77a8 Since both functions are responsible for converting LangChain messages to OpenAI format, I'm wondering which behavior is preferred. Should they be consistent? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This Pull Request refactors the langchain_openai package by replacing the three internal usages of the private helper function
_convert_message_to_dictwith calls to the public utility functionlangchain_core.messages.utils.convert_to_openai_messages.Issue: This PR is not for a issue but rather a discussion: Consolidate Langchain message to OpenAI message conversion implementations #31225