-
Notifications
You must be signed in to change notification settings - Fork 17.7k
Adding documentation for PGVectorStore #30950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Adding documentation for PGVectorStore #30950
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing a few errors in build.
One is straightforward: we require a standard set of headers in integrations pages:
ValueError: Document /home/runner/work/langchain/langchain/docs/docs/integrations/vectorstores/pgvectorstore.ipynb is missing headers:
- ## Setup
- ## Initialization
- ## Manage vector store
- ## Query vector store
- ## Usage for retrieval-augmented generation
- ## API reference
Separate from this, it's possible that we're not escaping a comparison operator correctly:
Error: MDX compilation failed for file "/vercel/path0/docs/docs/integrations/vectorstores/pgvectorstore.md"
Cause: Unexpected character `)` (U+0029) before name, expected a character that can start a name, such as a letter, `$`, or `_`
Details:
{
"column": 27,
"message": "Unexpected character `)` (U+0029) before name, expected a character that can start a name, such as a letter, `$`, or `_`",
"line": 327,
"name": "327:27",
"place": {
"line": 327,
"column": 27,
"offset": 10428,
"_index": 0,
"_bufferIndex": 12
},
"reason": "Unexpected character `)` (U+0029) before name, expected a character that can start a name, such as a letter, `$`, or `_`",
"ruleId": "unexpected-character",
"source": "micromark-extension-mdx-jsx",
"url": "https://github.com/micromark/micromark-extension-mdx-jsx#unexpected-character-at-expected-expect"
}
error Command failed with exit code 1.
Found this if helpful.
@ccurme thanks for the help, escaping the comparison operator did the trick. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be confusing to users to have PGVector
and PGVectorStore
side by side. When should they use one vs. the other? Are we going to deprecate PGVector? Should we remove it from the docs (adding redirects to the v0.2 docs)?
@ccurme We can update the docs to redirect to |
We are working with Eugene to deprecate PGVector; however, there are a few additional features Eugene is requesting before the deprecation. |
@averikitsch where there any remaining features that were not on parity with PGVector? I think you added db agnostic filtering already? |
That is correct. We don't current support nested JSON metadata, but overall we have filtering support. There are no other missing features. |
Thank you for contributing to LangChain!
Adding documentation for PGVectorStore:
docs: Adding documentation for the new PGVectorStore as a part of langchain-postgres
Add docs: The notebook for PGVectorStore is now added to the directory
docs/docs/integrations
.As a part of this change, we've also updated the VectorStore features table and VectorStoreTabs