fix(gitbook): Makes content_selector work well when configured as a CSS selector#516
Open
wForget wants to merge 1 commit intolangchain-ai:mainfrom
Open
fix(gitbook): Makes content_selector work well when configured as a CSS selector#516wForget wants to merge 1 commit intolangchain-ai:mainfrom
wForget wants to merge 1 commit intolangchain-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although the current description of
content_selectoris:The CSS selector for the content to load., it seems to only be configurable as an HTML element name.Use
soup.select_one(self.content_selector)instead ofsoup.find(self.content_selector)to makescontent_selector` work well when it configured as a CSS selectorcloses #515