refactor: deduplicate tool execution logic in HITL edit handler #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**`refactor: deduplicate tool execution logic in edit handler Replace duplicated if/elif blocks for write_email and schedule_meeting with a single conditional using EDITABLE_TOOLS constant. Improves maintainability and makes adding new editable tools easier.`**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced duplicated if/elif blocks for write_email and schedule_meeting tool execution with a single conditional using an EDITABLE_TOOLS constant. This improves code maintainability and makes adding new editable tools easier by simply updating the constant array.
Changes:
Introduced EDITABLE_TOOLS constant to define which tools support editing
Consolidated duplicate tool execution logic into a single code path
Updated both Python source file and Jupyter notebook
Preserved existing functionality and error handling