Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sam2 large video support #335

Merged
merged 30 commits into from
Jan 7, 2025
Merged

sam2 large video support #335

merged 30 commits into from
Jan 7, 2025

Conversation

hrnn
Copy link
Member

@hrnn hrnn commented Dec 31, 2024

  • This is the initial effort to support large videos (longer than 1m).
  • It splits the input video into segments, so instead of process the entire video, we process segments of it.
  • The process_segment function handles the object detection within each segment, while the merge_segments function combines the detections from all segments. The merging process considers object overlap and identity across segments to ensure consistent tracking throughout the video.

Comparison between current result and the pull request result

final_output_pr.mp4

@hrnn hrnn self-assigned this Dec 31, 2024
@hrnn hrnn requested a review from camiloaz January 2, 2025 17:37
@hrnn hrnn marked this pull request as ready for review January 6, 2025 20:36
@hrnn hrnn requested a review from dillonalaird January 6, 2025 20:50
Copy link
Member

@camiloaz camiloaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I am assuming there were already tests for the object tracking case?

@camiloaz
Copy link
Member

camiloaz commented Jan 6, 2025

LGTM! I am assuming there were already tests for the object tracking case?

let's wait for @dillonalaird review.

Copy link
Member

@dillonalaird dillonalaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments on how to handle the display data

vision_agent/tools/tools.py Outdated Show resolved Hide resolved
vision_agent/utils/video_tracking.py Show resolved Hide resolved
Copy link
Member

@dillonalaird dillonalaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hrnn hrnn merged commit df3fff5 into landing-ai:main Jan 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants