Skip to content

Use repository root as the base path for worktree creation #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Use repository root as the base path for worktree creation #159

merged 1 commit into from
Jun 24, 2025

Conversation

lambdalisue
Copy link
Owner

@lambdalisue lambdalisue commented Jun 24, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features
    • Improved the process for creating new Git worktrees by automatically suggesting paths anchored to the repository's root directory.
  • Enhancements
    • Worktree creation prompts now provide absolute paths based on the actual Git root, ensuring more accurate and consistent worktree locations.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 24, 2025 •
edited
Loading

Walkthrough

The changes update the logic for creating new Git worktrees by dynamically resolving the Git root directory using a new helper function. The revParse function is now exported to support this, and the default worktree path is anchored to the Git root instead of the current working directory.

Changes

File(s) Summary
denops/gin/action/worktree_new.ts Adds findRoot helper to resolve Git root; updates worktree path logic to use Git root.
denops/gin/git/finder.ts Changes revParse from private to exported for use in other modules.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant worktree_new.ts
    participant finder.ts

    User->>worktree_new.ts: Initiate new worktree creation
    worktree_new.ts->>finder.ts: Call revParse(--git-common-dir)
    finder.ts-->>worktree_new.ts: Return Git root directory
    worktree_new.ts->>User: Prompt with default path anchored at Git root
    User-->>worktree_new.ts: Provide worktree path
    worktree_new.ts->>finder.ts: Proceed with worktree creation
Loading

Possibly related PRs

Poem

A hop to the root, where the worktrees grow,
Now paths are resolved from the Git below.
With revParse exported, the journey is clear,
New worktrees sprout where the roots appear.
🐇✨
From burrow to branch, the code is neat—
Anchored in logic, never offbeat!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 620f56a and ca9aca7.

📒 Files selected for processing (2)
  • denops/gin/action/worktree_new.ts (4 hunks)
  • denops/gin/git/finder.ts (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
denops/gin/action/worktree_new.ts (1)
denops/gin/git/finder.ts (1)
  • revParse (107-111)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: test (ubuntu-latest, 1.x, v9.1.0448, v0.10.0)
  • GitHub Check: test (macos-latest, 1.x, v9.1.0448, v0.10.0)
  • GitHub Check: test (macos-latest, 1.45.0, v9.1.0448, v0.10.0)
  • GitHub Check: test (windows-latest, 1.x, v9.1.0448, v0.10.0)
  • GitHub Check: test (windows-latest, 1.45.0, v9.1.0448, v0.10.0)
  • GitHub Check: test (ubuntu-latest, 1.45.0, v9.1.0448, v0.10.0)
🔇 Additional comments (5)
denops/gin/git/finder.ts (1)

107-107: LGTM! Clean export for reusability.

The export of revParse enables its reuse in other modules while maintaining the existing implementation. The function is well-implemented and handles Git command execution properly.

denops/gin/action/worktree_new.ts (4)

2-2: LGTM! All necessary imports for the new functionality.

The added imports are essential for the repository root resolution logic and are all properly utilized in the implementation.

Also applies to: 5-6, 8-8

49-50: LGTM! Proper implementation of repository root anchoring.

The changes correctly resolve the Git repository root and use it as the base for worktree paths, achieving the PR objective of anchoring worktrees to the repository root instead of the current working directory.

Also applies to: 56-56

78-79: LGTM! Consistent implementation matching doNew pattern.

The changes in doNewOrphan correctly follow the same pattern as doNew, ensuring consistent behavior for both regular and orphan worktree creation.

Also applies to: 82-82

97-106: LGTM! Well-implemented Git root resolution with appropriate fallback.

The findRoot function correctly uses --git-common-dir to locate the Git directory and returns its parent as the repository root. The error handling that returns an empty string provides a reasonable fallback to relative path behavior when Git root cannot be determined.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link

codecov bot commented Jun 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.30%. Comparing base (620f56a) to head (ca9aca7).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   60.30%   60.30%           
=======================================
  Files          17       17           
  Lines         912      912           
  Branches      120      120           
=======================================
  Hits          550      550           
  Misses        362      362

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lambdalisue lambdalisue merged commit 7ef9dfa into main Jun 24, 2025
9 checks passed
@lambdalisue lambdalisue deleted the fix-worktree-support branch June 24, 2025 08:12
@coderabbitai coderabbitai bot mentioned this pull request Jun 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lambdalisue