Skip to content

fix: ArcTooBig parameter order in assert_le_felt #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 27, 2025
+4 −2
Merged

fix: ArcTooBig parameter order in assert_le_felt #2234

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f28d41
Fix ArcTooBig parameter order in assert_le_felt
VolodymyrBg Oct 17, 2025
d6ed9fe
add changelog
VolodymyrBg Oct 20, 2025
c8255b3
Merge branch 'main' into fix/assert-le-felt-arctoobig-order
VolodymyrBg Oct 20, 2025
7c4c45b
Merge branch 'main' into fix/assert-le-felt-arctoobig-order
JulianGCalderon Oct 22, 2025
d4ca858
Merge branch 'main' into fix/assert-le-felt-arctoobig-order
VolodymyrBg Oct 24, 2025
2061416
Merge branch 'main' into fix/assert-le-felt-arctoobig-order
JulianGCalderon Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

#### Upcoming Changes

* fix: ArcTooBig parameter order in assert_le_felt. [#2234](https://github.com/lambdaclass/cairo-vm/pull/2234)

* fix: Remove unused dependency getrandom for cairo1-run, and serde_json for wasm-demo-cairo1 [#2238](https://github.com/lambdaclass/cairo-vm/pull/2238)

* chore: Unify deps makefile target [#2211](https://github.com/lambdaclass/cairo-vm/pull/2211)
Expand Down
4 changes: 2 additions & 2 deletions vm/src/hint_processor/builtin_hint_processor/math_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,9 @@ pub fn assert_le_felt(
if lengths_and_indices[0].0 > &prime_div3 || lengths_and_indices[1].0 > &prime_div2 {
return Err(HintError::ArcTooBig(Box::new((
Felt252::from(&lengths_and_indices[0].0.clone()),
Felt252::from(&prime_div2),
Felt252::from(&lengths_and_indices[1].0.clone()),
Felt252::from(&prime_div3),
Felt252::from(&lengths_and_indices[1].0.clone()),
Felt252::from(&prime_div2),
))));
}

Expand Down
Loading