-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest JDKs #107
Use latest JDKs #107
Conversation
Travis CI didn't run on this change. Any ideas why? |
Looking at https://travis-ci.com/lagom/lagom-samples/requests, my guess is that this pull request initially targeted the wrong branch, and Travis CI doesn't see an event when the branch target is updated. I'll close and reopen to trigger it. We should probably also set it up as a required check for the 1.5.x and 1.6.x branches, so that things aren't merged by mistake without the build running. Update: raised as #108. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Is there any easier way to specify the latest patch build of each release? Otherwise this will be a constant chore. For example, OpenJDK 8u232 and 11.0.5 were both just tagged today, and I would expect AdoptOpenJDK releases to follow soon.
Had to update the Java 8 version string: 37c2f75 |
Backport: #110 |
There certainly is. We should use the same spell we use on other repos. |
raised #111 |
No description provided.