Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix end function when piping on request #832

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

aaharu
Copy link

@aaharu aaharu commented Feb 27, 2024

Checklist

rework of #742

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@thehenrymcintosh
Copy link

I'm also having this issue - thank you for the fix @aaharu

@nabramow
Copy link

nabramow commented Dec 13, 2024

Would also love to see this PR go in! We're running into the issue with our repo!

@@ -133,7 +133,7 @@ class Test extends Request {
*
* @param {?Error} resError
* @param {Response} res
* @param {Function} fn
* @param {?Function} fn
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review your commit and fix these typos

Copy link
Collaborator

@titanism titanism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants