Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(BA-693): Failure of whole image rescanning when there is a misconfigured container registry #3652

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(BA-693): Failure of whole image rescanning when there is a misconfigured container registry #3652

wants to merge 2 commits into from

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Feb 11, 2025 •
edited
Loading

Fixes #3650 (BA-693).

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

@jopemachine jopemachine changed the title fix: Wrong exception handling of fetch_repositories fix(BA-693): Wrong exception handling of fetch_repositories Feb 11, 2025
@github-actions github-actions bot added comp:manager Related to Manager component size:XS ~10 LoC labels Feb 11, 2025
@jopemachine jopemachine added the type:bug Reports about that are not working label Feb 11, 2025
@github-actions github-actions bot added size:S 10~30 LoC size:M 30~100 LoC and removed size:XS ~10 LoC size:S 10~30 LoC labels Feb 11, 2025
@jopemachine jopemachine force-pushed the fix_whole_image_rescan_fail_when_misconfigured_registry_row_exist branch from f45646d to da9135b Compare February 11, 2025 07:46
@github-actions github-actions bot added size:S 10~30 LoC and removed size:M 30~100 LoC labels Feb 11, 2025
@jopemachine jopemachine added this to the 23.09 milestone Feb 11, 2025
@jopemachine jopemachine changed the title fix(BA-693): Wrong exception handling of fetch_repositories fix(BA-693): Failure of the whole image rescanning task when there is a misconfigured container registry Feb 11, 2025
@jopemachine jopemachine changed the title fix(BA-693): Failure of the whole image rescanning task when there is a misconfigured container registry fix(BA-693): Failure of the whole image rescanning when there is a misconfigured container registry Feb 11, 2025
@jopemachine jopemachine changed the title fix(BA-693): Failure of the whole image rescanning when there is a misconfigured container registry fix(BA-693): Failure of whole image rescanning when there is a misconfigured container registry Feb 11, 2025
@jopemachine jopemachine marked this pull request as ready for review February 13, 2025 06:23
HyeockJinKim
HyeockJinKim approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@HyeockJinKim HyeockJinKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jopemachine
Copy link
Member Author

jopemachine commented Feb 13, 2025 •
edited
Loading

Future tasks:

Implement a method to propagate errors to the client when only some tasks within a BgTask fail.
See #3700.

@jopemachine jopemachine mentioned this pull request Feb 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyeockJinKim HyeockJinKim HyeockJinKim approved these changes

Assignees

@jopemachine jopemachine

Labels
comp:manager Related to Manager component size:S 10~30 LoC type:bug Reports about that are not working
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.

Failure of the image rescan when there is a misconfigured container registry row
2 participants
@jopemachine @HyeockJinKim