Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BA-674): Implement Image Soft/Hard Delete APIs #3628

Draft
wants to merge 6 commits into
base: topic/02-10-feat_add_status_to_image_imagenode_gql_field
Choose a base branch
from

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Feb 10, 2025

Resolves #3617 (BA-674)

Changes

Added CLI commands

  • mgr image purge

Updated CLI commands

  • mgr image forget

Added mutations

  • PurgeImageById
  • PurgeImage

Updated mutations

  • ForgetImageById
  • ForgetImage
  • ClearImages

Note

There is no Image REST API, so it has been omitted.


Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

📚 Documentation preview 📚: https://sorna--3628.org.readthedocs.build/en/3628/


📚 Documentation preview 📚: https://sorna-ko--3628.org.readthedocs.build/ko/3628/

@github-actions github-actions bot added comp:manager Related to Manager component size:L 100~500 LoC labels Feb 10, 2025
Copy link
Member Author

jopemachine commented Feb 10, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jopemachine jopemachine changed the title feat: Implment Image Soft/Hard Delete APIs feat: Implement Image Soft/Hard Delete APIs Feb 10, 2025
@jopemachine jopemachine changed the title feat: Implement Image Soft/Hard Delete APIs feat(BA-674): Implement Image Soft/Hard Delete APIs Feb 10, 2025
@github-actions github-actions bot added the area:docs Documentations label Feb 10, 2025
@jopemachine jopemachine force-pushed the topic/02-10-feat_implment_image_soft_hard_delete_apis branch from 55c29b4 to 574e5d7 Compare February 10, 2025 04:53
@jopemachine jopemachine added this to the 25Q1 milestone Feb 10, 2025
@github-actions github-actions bot added comp:client Related to Client component comp:cli Related to CLI component labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:cli Related to CLI component comp:client Related to Client component comp:manager Related to Manager component size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant