-
Notifications
You must be signed in to change notification settings - Fork 3
Logger Updates (LJLogM v1.11 and LJStreamM 1.12) #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sjarman28
wants to merge
97
commits into
develop
Choose a base branch
from
feature-logger-updates-12-2024
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change Interval (ms) to Scan Interval (ms) Update text about configuring device I/O Change Amplitude to Amplitude - Scaled in the logger charts Change Time to Seconds in the logger charts
LJStreamM still needs an update to properly load exp configs passed to config panel
Still need to reorganize the write to file utilities. Fixed bug in logger graph processing VI.
Removed write to file util used in LJLogM and replaced it with common VIs shared between LJLogM and LJStreamM. Reorganize the file structure of logger write to file VIs.
…fig (introduced during LJLogM program flow refactor).
Scaling errors will now be processed and a message displayed. Changed TCVoltsToTemp to output -9999 so it is consistent with AIN_EF behavior. Made a change so one scaling equation error does not error out all other scaling equation processing.
Also changed default font for loggers to Arial and set minimum window sizes for the loggers and config panel. This supposedly helps avoid front panel scaling issues on different monitor resolutions.
The loggers will now try to open a device using the device open configuration file, then if that fails prompt the user if they want to open the first found device.
* Removed Device open save and load buttons * Added common registers list pop-up * Added I/O config save current as power-up and load factory defaults buttons
Unchecked the show front panel when loaded setting.
…nfig text on logger config panel.
* Changed LJLogM to allow modifications to 'Data File Prefix' while logging is enabled. This is consistent with longstanding LJStreamM behavior. * Trim window size for both LJLogM and LJStreamM. * Recolor and trim logger config panel window.
* Fix bug where LJStreamM did not update the data file prefix once the max file size was exceeded. * Minor cosmetic tweaks to logger write to file VI diagram.
The 'Currently Writing' bool was not being set correctly which caused a new file to be generated every iteration.
…stream is active.
Previously, the log file was only created when the next log interval occurred after write to file was selected. The change creates the file as soon as write to file is selected. This updates the current data file indicator sooner, making it clearer that log to file is working.
extended device open identifier field to better display longer IP addresses. Changed identifier to a ring buffer so ANY can be more easily selected.
* Changed the wait interval timing so that it is more consistently 500ms when not logging. * Moved the wait period to the end of the loop iteration, which helps responsiveness of front panel controls.
LJLogM v1.11 LJStreamM v1.12
If a config file does not exist, load defaults without warning the user. Usually if the config file does not exist it means this is the first time running the program, and we do not want new users to see a warning about the config not existing.
LJLogM v1.12 LJStreamM v1.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LJStreamM changes:
1.11: Reworked configs including adding a configuration panel. Moved the 'Change Working Directory' button to the configuration panel. Refactored the write to file functionality. Refactored the block diagram. Added scaling equation error messaging. Renamed the 'experiment' config to 'program' config. Added register write functionality to the configuration panel. Increased front panel text size, changed font to Arial (monospace), and set the minimum panel size. Added support for 96 channels. Added logger row modification controls. Note: program configs with 96 channels in v1.11 would not be recognized as valid in v1.10.
1.12: Made minor Visual tweaks to the front panel. Made optimizations to scaling equation processing and front panel responsiveness. Disabled the scaling equation control while stream is active.
LJLogM changes:
1.10: Reworked configs including adding a configuration panel. Moved the 'Change Working Directory' button to the configuration panel. Refactored the write to file functionality. Refactored the block diagram. Added scaling equation error messaging. Renamed the 'experiment' config to 'program' config. Added register write functionality to the configuration panel. Increased front panel text size, changed font to Arial (monospace), and set the minimum panel size. Added support for 96 channels. Added the 'Log Every n Scans' control. Added row modification controls. Note: program configs with 96 channels in v1.10 would not be recognized as valid in v1.09
1.11: Made minor Visual tweaks to the front panel. Made optimizations to scaling equation processing and front panel responsiveness.