Wait for fs operations in registerDir #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Either this, or promisifying this method is required in order to use lab-di in our projects without the build sometimes breaking. If we want to make this method async, then we have to wait for it in every project we use it in, so it should be decided early in order to avoid the neccessity of any dependant packages' refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either this, or promisifying this method is required in order to use lab-di
in our projects without the build sometimes breaking.
If we want to make this method async, then we have to wait for it in every
project we use it in, so it should be decided early in order to avoid the necessity
of any dependant packages' refactor.