Skip to content

Allow S3 buckets in different regions #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

frodeanonsen
Copy link

This will fix an issue mentioned in #170 to allow the PKI bucket to exist in different regions.

@mcameron
Copy link

Also required:

diff --git a/scripts/get-ca b/scripts/get-ca
index 15682a0..cd05240 100755
--- a/scripts/get-ca
+++ b/scripts/get-ca
@@ -8,4 +8,4 @@ CA_PATH="s3://$PKI_S3_BUCKET/ca.pem"

 mkdir -p $DIR_SSL

-_retry "❤ Grabbing $CA_PATH" aws s3 cp $CA_PATH $DIR_SSL
+_retry "❤ Grabbing $CA_PATH" aws --region $AWS_REGION s3 cp $CA_PATH $DIR_SSL

@krlng
Copy link

krlng commented Jun 16, 2017

Also ran into #170 and tried the s3-buckets-in-regions fix: Works like a charm. Would love to see it in merged.

@@ -27,7 +27,7 @@ trap finish EXIT
# test cfssl connection -- retry until up
#
until printf "." && curl -d '{"label":"primary"}' http://localhost:8888/api/v1/cfssl/info &>/dev/null
do sleep 2.5; done; echo "✓
do sleep 2.5; done; echo "✓"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have been resolved, at least 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants