-
Notifications
You must be signed in to change notification settings - Fork 310
feat(cel): add ValidatingPolicy for aws-node IRSA + tests #1328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
syedazeez337
wants to merge
15
commits into
kyverno:main
Choose a base branch
from
syedazeez337:feat/cel-require-aws-node-irsa
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(cel): add ValidatingPolicy for aws-node IRSA + tests #1328
syedazeez337
wants to merge
15
commits into
kyverno:main
from
syedazeez337:feat/cel-require-aws-node-irsa
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Syed Azeez <[email protected]>
Author
JimBugwadia
approved these changes
Oct 22, 2025
Member
|
The current test structure is failing our expected structure. @syedazeez337 can you please take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Summary
Convert legacy
aws/require-aws-node-irsato a CELValidatingPolicyunderaws-cel/require-aws-node-irsa, withkyverno testfixtures.What changed
Added:
aws-cel/require-aws-node-irsa/policy.yaml(CELValidatingPolicy)Added tests:
aws-cel/require-aws-node-irsa/tests/pass(uses non-aws-nodeSA → pass)aws-cel/require-aws-node-irsa/tests/fail(usesaws-nodeSA → fail)No changes to the legacy sample.
Why
Part of the ongoing migration of sample policies to CEL-based types for better performance, native K8s alignment, and clearer testability.
Behavior (parity with legacy)
DaemonSetkube-system/aws-node only.spec.template.spec.serviceAccountName == "aws-node".validationActions: Audit(equivalent tovalidationFailureAction: Audit).Spec details
matchConstraints.resourceRules:apps/v1,daemonsets,CREATE|UPDATEmatchConditions: name/namespace pinning (kube-system+aws-node)validations[0].expression:object.spec.template.spec.serviceAccountName != "aws-node"How I tested
Notes
aws-nodeSA; use IRSA-specific SA).aws-nodeSA (vs. simply “not equal toaws-node”).