-
Notifications
You must be signed in to change notification settings - Fork 310
Best practices vpol #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Best practices vpol #1292
Conversation
Signed-off-by: Mohd Kamaal <[email protected]>
Signed-off-by: Mohd Kamaal <[email protected]>
Signed-off-by: Mohd Kamaal <[email protected]>
Signed-off-by: Mohd Kamaal <[email protected]>
Signed-off-by: Mohd Kamaal <[email protected]>
|
would be ready for review once this issue gets completed kyverno/kyverno#13089 |
Signed-off-by: Mohd Kamaal <[email protected]>
Signed-off-by: Mohd Kamaal <[email protected]>
Signed-off-by: Mohd Kamaal <[email protected]>
|
@Mohdcode - there's an issue on CRD support: Does this CLI test run in-cluster? And there's another issue for supporting CRDs off-cluster in CLI kyverno/kyverno#13427. |
|
The test fails off-cluster, but it passes on a real cluster. You're right, we need support for CRDs. |
|
@Mohdcode - can you please address the test failures so we can get this merged? Looks like there is an API version mismatch: |
|
Kyverno CLI maintains a static GVK-to-GVR mapping. Because of this limitation, the CLI fails when testing resources whose API versions or kinds aren’t listed there. |
|
@Mohdcode - do we want to allow passing in a mapping? |
MariamFahmy98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add the new directory to the CI so that the chainsaw tests are executed?
Signed-off-by: Mohd Kamaal <[email protected]>
32062ce
Related Issue(s)
kyverno/kyverno#12085
Description
add best-practices-vpol
dir with prefix
addwould be converted after the generatePolicy crd releaseChecklist