fix: improve test summary reporting by adjusting cleanup order #2535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: A-5ingh <[email protected]>
A-5ingh
force-pushed
the
bugfix/cleanup-mark-test
branch
from
ed9952f to
b0ab9a0
Compare
Signed-off-by: A-5ingh <[email protected]>
A-5ingh
force-pushed
the
bugfix/cleanup-mark-test
branch
from
d17b767 to
9092318
Compare
Contributor
Author
|
@eddycharly Can you please review this? |
Member
|
@A-5ingh what's the difference ? |
Contributor
Author
I have changed the order in order to fix the summary report. |
eddycharly
reviewed
Nov 28, 2025
| Duration: metav1.Duration{Duration: time.Duration(1) * time.Second}, | ||
| }, | ||
| }, | ||
| { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Related issue
Fixes #2531
Proposed Changes
Setup summary - must run after all other cleanup (registered first to run last in LIFO order)
Checklist
Further Comments