Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(local-nav): token updates #322

Open
wants to merge 8 commits into
base: next
Choose a base branch
from
Open

Conversation

brian-patrick-3
Copy link
Contributor

@brian-patrick-3 brian-patrick-3 commented Jan 14, 2025

Summary

Updated Local Nav to use new color tokens based on Global Navigation design updates. Also fixed some styles that appeared to have broken due to merges.

ADO Story Link

https://dev.azure.com/Kyndryl/Shidoka%20-%20Bridge%20Design%20System/_workitems/edit/2003563/?view=edit

Figma Link

Notes

  • Local Nav still to be revisited after this to see if further design changes to be made for 2.0 release.
  • Some colors for the various Link states seem like they need to be tweaked further. Discussion started in Figma here.

@brian-patrick-3 brian-patrick-3 requested review from a team January 14, 2025 16:10
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for shidoka-applications ready!

Name Link
🔨 Latest commit e021134
🔍 Latest deploy log https://app.netlify.com/sites/shidoka-applications/deploys/679129d699921b0008220608
😎 Deploy Preview https://deploy-preview-322--shidoka-applications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wbarbee
Copy link
Contributor

wbarbee commented Jan 14, 2025

this LGTM, the only thing to check is a strange effect that is likely just how this is presented in Storybook where the pinned/unpinned nav has an semi-transparent background extending past the nav. should it appear the same as long as the nav is open, regardless of whether it's pinned or not?

just making sure this is as intended:
Screenshot 2025-01-14 at 10 23 44 AM
Screenshot 2025-01-14 at 10 23 38 AM

@brian-patrick-3
Copy link
Contributor Author

just making sure this is as intended

Yeah the backdrop is only intended to be visible when expanded and not pinned.

Copy link
Contributor

@kumarivijeta kumarivijeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link 1 appears disabled in Light mode but enabled in Dark mode.

Screenshot 2025-01-15 at 10 44 25 AM Screenshot 2025-01-15 at 10 39 19 AM

@brian-patrick-3
Copy link
Contributor Author

Link 1 appears disabled in Light mode but enabled in Dark mode.

Yes, the active state, already raised in Figma, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants