-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(local-nav): token updates #322
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for shidoka-applications ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
this LGTM, the only thing to check is a strange effect that is likely just how this is presented in Storybook where the pinned/unpinned nav has an semi-transparent background extending past the nav. should it appear the same as long as the nav is open, regardless of whether it's pinned or not? |
Yeah the backdrop is only intended to be visible when expanded and not pinned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the active state, already raised in Figma, thanks! |
Summary
Updated Local Nav to use new color tokens based on Global Navigation design updates. Also fixed some styles that appeared to have broken due to merges.
ADO Story Link
https://dev.azure.com/Kyndryl/Shidoka%20-%20Bridge%20Design%20System/_workitems/edit/2003563/?view=edit
Figma Link
Notes