Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle Race Condition for Istio Gateway Secret #2077

Closed
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
47f48f4
feat: Introduce Dedicated Istio Gateway Secret
LeelaChacha Nov 3, 2024
2b89a3a
Merge branch 'main' into feature/#1890-tls-cert-rotation-migration
LeelaChacha Nov 3, 2024
a8217b5
refactor: Lint
LeelaChacha Nov 4, 2024
c76cffa
refactor: Lint
LeelaChacha Nov 4, 2024
d4935ad
test: Simulate Gateway Secret in Watcher Suite
LeelaChacha Nov 4, 2024
b71c975
refactor: gofumpt and gci
LeelaChacha Nov 4, 2024
897dd0f
fix: ca rotation e2e test
LeelaChacha Nov 4, 2024
5cb068d
test: ca rotation e2e fix
LeelaChacha Nov 6, 2024
0596448
Merge branch 'main' into feature/#1890-tls-cert-rotation-migration
LeelaChacha Nov 6, 2024
d48fd6f
test: ca rotation e2e fix
LeelaChacha Nov 7, 2024
6e35338
fix: give controller-manager permission to update istio-gateway-secret
LeelaChacha Nov 7, 2024
e4edfb6
Merge branch 'main' into feature/#1890-tls-cert-rotation-migration
LeelaChacha Nov 7, 2024
aeacc42
fix: give controller-manager permission to update istio-gateway-secret
LeelaChacha Nov 7, 2024
758c4d3
fix: KLM image name in kustomization
LeelaChacha Nov 7, 2024
8cb3b38
Merge branch 'main' into feature/#1890-tls-cert-rotation-migration
LeelaChacha Nov 11, 2024
ed7ea63
refactor: Rename zerodw package
LeelaChacha Nov 11, 2024
7016aac
refactor: PR Review
LeelaChacha Nov 14, 2024
bf0d76b
Merge branch 'main' into feature/#1890-tls-cert-rotation-migration
LeelaChacha Nov 14, 2024
b63ffe4
refactor: PR Review
LeelaChacha Nov 14, 2024
b467d13
refactor: gci
LeelaChacha Nov 14, 2024
333fd09
refactor: hide gateway secret name
LeelaChacha Nov 14, 2024
f7fc41c
test: add e2e test for istio gateway secret rotation
LeelaChacha Nov 15, 2024
ce69e8c
refactor: gci and gofumpt
LeelaChacha Nov 15, 2024
16848db
Merge branch 'main' into feature/#1890-tls-cert-rotation-migration
LeelaChacha Nov 15, 2024
5e71352
fix: flags_test.go
LeelaChacha Nov 15, 2024
11779fe
chore: remove debug print statement
LeelaChacha Nov 15, 2024
34363c6
fix: remove background context
LeelaChacha Nov 15, 2024
55fe04b
fix: test logics
LeelaChacha Nov 18, 2024
0ceb574
Merge branch 'main' into feature/#1890-tls-cert-rotation-migration
LeelaChacha Nov 18, 2024
45691cb
refactor: go routine style in main
LeelaChacha Nov 18, 2024
b260cbf
fix: KLM health check
LeelaChacha Nov 18, 2024
7f1110c
fix: Istion Rotation E2E Check
LeelaChacha Nov 18, 2024
0453158
fix: Istion Rotation E2E Check
LeelaChacha Nov 19, 2024
645dbdb
test: Add Unit Tests for handler.go
LeelaChacha Nov 20, 2024
25fb3a2
fix: Event name in unit test
LeelaChacha Nov 20, 2024
2fa53c8
refactor: require.Equal parameter order
LeelaChacha Nov 20, 2024
c8d2b0e
Merge branch 'main' into feature/#1890-tls-cert-rotation-migration
LeelaChacha Nov 20, 2024
9f6646d
refactor: shift namespace const to testutils package
LeelaChacha Nov 20, 2024
414f368
refactor: using require.Equal
LeelaChacha Nov 20, 2024
841b97d
refactor: PR comments
LeelaChacha Nov 21, 2024
cc784ea
Merge branch 'main' into feature/#1890-tls-cert-rotation-migration
LeelaChacha Nov 21, 2024
b03cd8f
refactor: handler unit test, remove secret manager interface
LeelaChacha Nov 25, 2024
43b4bcd
Merge branch 'main' into feature/#1890-tls-cert-rotation-migration
LeelaChacha Nov 25, 2024
4f899dc
refactor: lint gci and gofumpt
LeelaChacha Nov 25, 2024
8370566
refactor: unparam lint error
LeelaChacha Nov 25, 2024
6eccbd8
refactor: unparam lint error
LeelaChacha Nov 25, 2024
8490271
refactor: unparam lint error
LeelaChacha Nov 25, 2024
5aaaab9
Merge branch 'main' into feature/#1890-tls-cert-rotation-migration
LeelaChacha Nov 26, 2024
ca5e190
chore: add pkg/gatewaysecret unittest coverage
LeelaChacha Nov 27, 2024
203d529
chore: add pkg/gatewaysecret unittest coverage
LeelaChacha Nov 27, 2024
f098fc6
refactor: make ManageGatewaySecret private
LeelaChacha Nov 27, 2024
2207900
refactor: remove local testing artefacts
LeelaChacha Nov 27, 2024
e6459ac
fix(gatewaysecret/handler.go): Handle Existing Root Certificates
LeelaChacha Nov 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: unparam lint error
LeelaChacha committed Nov 25, 2024
commit 8490271f6de9325175d7853708e3c1096b9ec0e1
3 changes: 1 addition & 2 deletions pkg/gatewaysecret/handler_test.go
Original file line number Diff line number Diff line change
@@ -250,8 +250,7 @@ func TestWatchEvents(t *testing.T) {
waitGroup.Add(1)

calledTimes := 0
//nolint:unparam The function has to have this signature to be used in WatchEvents
mockManageSecretFunc := func(_ context.Context, _ *apicorev1.Secret) error {
mockManageSecretFunc := func(_ context.Context, _ *apicorev1.Secret) error { //nolint:unparam // The function has to have this signature to be used in WatchEvents
calledTimes += 1
return nil
}