Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce Dedicated Istio Gateway Secret #2004

Merged
merged 52 commits into from
Nov 27, 2024
Merged

feat: Introduce Dedicated Istio Gateway Secret #2004

merged 52 commits into from
Nov 27, 2024

Conversation

LeelaChacha
Copy link
Contributor

Closes #1890

@LeelaChacha LeelaChacha requested a review from a team as a code owner November 3, 2024 23:34
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 3, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2024
ruanxin
ruanxin reviewed Nov 11, 2024
View reviewed changes
pkg/zerodw/gateway.go Outdated Show resolved Hide resolved
ruanxin
ruanxin reviewed Nov 11, 2024
View reviewed changes
cmd/main.go Outdated Show resolved Hide resolved
Tomasz-Smelcerz-SAP
Tomasz-Smelcerz-SAP requested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Please update test coverage stats for the pkg/gatewaysecret package in the unit-test-coverage.yaml file.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 27, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 27, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 27, 2024
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP merged commit 388d602 into kyma-project:main Nov 27, 2024
64 of 65 checks passed
This was referenced Nov 29, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP approved these changes

@ruanxin ruanxin Awaiting requested review from ruanxin

Assignees

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: [Zero-Downtime] - safe migration
4 participants
@LeelaChacha @ruanxin @Tomasz-Smelcerz-SAP @kyma-bot