Escape dynamic values in settings fields to prevent malformed HTML #216
+7
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update ensures proper escaping of dynamic values in the plugin settings page to prevent malformed HTML output and improve compatibility with HTML content containing quotes or special characters.
Problem
The current implementation inserts unescaped values directly into input elements. When a user enters HTML containing quotes (e.g.,
class="sf-icon-star-empty"), the value attribute is prematurely terminated. This leads to malformed HTML in both the settings interface and the front-end rendering if the broken value is saved.Solution
This update wraps dynamic values using
esc_attr()for input fields. This function safely encodes content for use in thevalueattribute.Benefits
Credits