Repository navigation
Move the pinned version in the README to 0.9.4 - #36
Open
kylebegeman wants to merge 2 commits into
Open
kylebegeman wants to merge 2 commits into
kylebegeman wants to merge 2 commits into
Conversation
The quick start's pinned npx commands, the global install line, the action reference, and the adopt card all name the version being released, and the card's version comes from package.json, so the readme:check job fails until they move together. Receipt 0195. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The handoff described 0.9.4 as prepared on a branch, which stopped being true when #35 merged. It now names the state, the tag command, and the README pin move that has to land with it. Receipt 0195. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this is needed before the tag
Merging #35 put version 0.9.4 in
package.json, but the README's pinned commands and the adopt card still say 0.9.3. The card's version comes frompackage.json, sonpm run readme:checkregenerates it and fails on the difference. Master is red on the "Check README cards" job until this lands, and av0.9.4tag cut before it would publish a README whose quick start pins the previous version.What changed
npxcommands, the global install line, and thekylebegeman/ledger@v0.9.4action reference.assets/readme/adopt.svg, regenerated byscripts/readme-assets.mjs. The only difference is the version in the command line; the demo clock stays pinned.Verification
npm run readme:checkexits 0 with this commit and exits 1 without it.npm run ciexit 0: 494 tests, Ledger CI passed.🤖 Generated with Claude Code