Fixing two issues in RayMarcher and VolumeRendering#133
Open
jnhwkim wants to merge 1 commit intokwea123:masterfrom
Open
Fixing two issues in RayMarcher and VolumeRendering#133jnhwkim wants to merge 1 commit intokwea123:masterfrom
jnhwkim wants to merge 1 commit intokwea123:masterfrom
Conversation
This pull request addresses two issues that were identified in the RayMarcher code: 1. Random Order Aggregation in RayMarcher: Previously, the samples were being aggregated in a random order during the forward pass. To ensure correct calculations of dL_drays_o and dL_drays_d using rays_a, I have introduced a sorting mechanism to organize the aggregation process appropriately. Although this fix can be improved using CUDA implementation, it still perform well with reasonable speed. 2. Incorrect Gradient from Opacity: There was a problem with the gradient calculation from opacity, which has now been rectified. The changes made align the gradient calculation with the forward pass, ensuring accurate results. These fixes enhance the functionality and accuracy of the RayMarcher implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses two issues that were identified in the RayMarcher and Volume Rendering code:
Random Order Aggregation in RayMarcher: Previously, the samples were aggregated in random order during the forward pass. To ensure correct calculations of
dL_drays_oanddL_drays_dusingrays_a, I have introduced a sorting mechanism to organize the aggregation process appropriately. Although this fix can be improved using CUDA implementation, it still performs well with reasonable speed.Incorrect Gradient from Opacity: There was a problem with the gradient calculation from Opacity, which has now been rectified. The changes align the gradient calculation with the forward pass, ensuring accurate results. These fixes enhance the functionality and accuracy of the RayMarcher implementation.