feat: Add external iframe warning to plugin import confirmation #1058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #1055.
PR Checklist
Description
Problem
The initial implementation of the plugin security warning in #1055 did not account for
iframescreated dynamically via JavaScript. This allowed certain plugins to bypass the security check.Solution
This pull request enhances the detection mechanism to identify
iframescreated programmatically. This ensures that users are properly warned about all plugins that utilize external iframes, strengthening the security of the plugin system.Key Changes
UI example