Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deterministic an option. #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevinzakka
Copy link

For debugging and overfitting.

@kpertsch
Copy link
Contributor

Did you test whether this actually makes the data loader fully deterministic? For very large model training it can be good to have a deterministic data loader to avoid re-training on data upon resuming (eg if you do a total of <=1 epoch), so having an option for determinism could be great even beyond debugging use cases.

@kevinzakka
Copy link
Author

@kpertsch I did some testing in a notebook and it seemed deterministic but have to write a full unit test.

@peter-mitrano-bg
Copy link

I would find this addition useful, although possible we should also expose the arg in the from_tfrecords function not just from_rlds?

@peter-mitrano-bg
Copy link

peter-mitrano-bg commented Oct 29, 2024

And of course I tested and can confirm this works. Having this hard-coded to false is extra scary because the TF docs say that if shuffle_files=False then it will automatically set deterministic to true, but that I guess doesn't happen in this case 💀

https://www.tensorflow.org/datasets/determinism#with_shuffle_filestrue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants