This repository was archived by the owner on Oct 10, 2025. It is now read-only.
Fix QueryResult iterator exhaustion bug in Rust bindings #6034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toString() method in MaterializedQueryResult was incorrectly using the shared class member 'iterator' instead of the local 'iterator_' variable. This caused the shared iterator to be exhausted whenever toString() was called (e.g., when using Display trait in Rust). This made the QueryResult unusable for iteration after any display/print operation, causing the iterator to hang or return no results. Changed: - iterator->hasNext() to iterator_.hasNext() - iterator->getNext() to iterator_.getNext() This ensures toString() uses its own local iterator without affecting the shared iterator used by the Rust bindings. Fixes the issue where Rust QueryResult iterator would hang after Display.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toString() method in MaterializedQueryResult was incorrectly using the shared class member 'iterator' instead of the local 'iterator_' variable. This caused the shared iterator to be exhausted whenever toString() was called (e.g., when using Display trait in Rust).
This made the QueryResult unusable for iteration after any display/print operation, causing the iterator to hang or return no results.
Changed:
This ensures toString() uses its own local iterator without affecting the shared iterator used by the Rust bindings.
Fixes the issue where Rust QueryResult iterator would hang after Display.