test(e2e): escape shell special characters in token generation #15307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes a command injection vulnerability in the test framework's token generation methods. User-provided data (mesh names, service names, workload names, zone names, and scope values) was being embedded in shell command strings without proper escaping of single quotes.
Implementation information
Fixed four methods in
test/framework/universal_controlplane.go:GenerateDpToken: Escapes single quotes in mesh, service, and workload namesGenerateZoneIngressToken: Escapes single quotes in zone namesGenerateZoneEgressToken: Escapes single quotes in zone namesGenerateZoneToken: Escapes single quotes in zone names and scope arrays