use golang lint rules to ignore some warnings for better reading the …

…code

Signed-off-by: Icarus Wu <[email protected]>

.golangci.yml

@@ -141,6 +141,12 @@ issues:
     - linters:
         - gocritic
       text: "appendAssign: append result not assigned to the same slice" # None of the instances of this in Kuma were bugs.
+    - linters:
+        - gocritic
+      text: "elseif: can replace 'else {if cond {}}' with 'else if cond {}'" # None of the instances of this in Kuma were bugs.
+    - linters:
+        - gosimple
+      text: "S1008: should use 'return overlapKeyCount != 0' instead of 'if overlapKeyCount == 0 { return false }; return true'" # Ignore this to better read the code
     - linters:
         - staticcheck
       text: "SA1019: package sigs.k8s.io/controller-runtime/pkg/client/fake is deprecated" # https://github.com/kumahq/kuma/issues/2460

pkg/plugins/policies/core/rules/rules.go

@@ -163,7 +163,7 @@ func (ss Subset) ContainsElement(element Element) bool {
 			}
 		} else {
 			// for those items that don't exist in element should not make an impact
-			if tag.Not == false {
+			if !tag.Not {
 				return false
 			}
 		}