chore: Several small cleanup amends around K named components #3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: John Cowen <[email protected]>
johncowen
force-pushed
the
chore/k-cleanup
branch
2 times, most recently
from
37a8efa to
03f2378
Compare
Signed-off-by: John Cowen <[email protected]>
johncowen
force-pushed
the
chore/k-cleanup
branch
from
03f2378 to
62840f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through and moved (almost) any remaining K components to use X components instead.
We still use K components in two instances:
XTableand<XCollection :variant="table">I noticed a couple of other things whilst doing this and amended here seeing as this is one of those "random bits" PRs, please ask if anything isn't clear 👍