passt: Fix docs #916

oshoval · 2025-08-25T14:40:32Z

What this PR does / why we need it:
Update docs about cni daemonSet.
Update outdated parts.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Design: A design document was considered and is present (link) or not required
PR: The PR description is expressive enough and will help future contributors
Code: Write code that humans can understand and Keep it simple
Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
Upgrade: Impact of this change on upgrade flows was considered and addressed if required
Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
Community: Announcement to kubevirt-dev was considered

Release note:

None

kubevirt-bot · 2025-08-25T14:40:35Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

orelmisan · 2025-09-01T13:01:46Z

/cc @nirdothan

nirdothan

Thanks @oshoval please see my comments below.

docs/network/net_binding_plugins/passt.md

aburdenthehand · 2025-09-17T12:26:29Z

@oshoval It looks like I also have a PR that touches some of the same content (feature gates, lifecycle and admonition updates): #926
Do you want to have a quick look at that since it updates all three plugin bindings and it would better to be consistent across them.

oshoval · 2025-09-17T13:42:45Z

@oshoval It looks like I also have a PR that touches some of the same content (feature gates, lifecycle and admonition updates): #926 Do you want to have a quick look at that since it updates all three plugin bindings and it would better to be consistent across them.

Hi, took a look, will look deeper again, but meanwhile i think we dont need to create dependecy between the 2 PRs, whatever the merge order will be, the 2nd will adapt accordingly.
It is both simpler, and for example about FG, the FG that this PR mention is a new optional one, not for the network binding feature as a whole (that FG was removed), but for an optional optimization dedicated for Passt.
This is something unique for Passt, and creating dependency between the PRs, will just confuse and complicate things.

Thanks

kubevirt-bot · 2025-09-24T13:10:01Z

Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

orelmisan

Thank you for the PR @oshoval!
Please see the comments inline.

orelmisan · 2025-09-29T12:32:18Z

docs/network/net_binding_plugins/passt.md


 ## Passt network binding plugin
-[v1.1.0]
+[v1.6.0]


Could you please elaborate on the necessity of this change, considering the passt binding plugin was introduced in v1.1.0

orelmisan · 2025-09-29T12:35:40Z

docs/network/net_binding_plugins/passt.md


 And in detail:

 ### Passt CNI deployment on nodes


Since the option to deploy the CNI via a daemonset is only available starting v1.6, I suggest that we will keep both deployment options.
Please also consider giving a few words about the relevant artifacts KubeVirt releases (CNI binary and a container image containing the CNI binary).

orelmisan · 2025-09-29T12:39:17Z

docs/network/net_binding_plugins/passt.md

 kind: NetworkAttachmentDefinition
 metadata:
-  name: netbindingpasst
+  name: primary-udn-kubevirt-binding


Could you please explain the rationale for this change? Additionally, the name used here is a downstream-specific term that should be avoided; let's replace it with a more generic one.

orelmisan · 2025-09-29T12:39:28Z

docs/network/net_binding_plugins/passt.md

  config: '{
            "cniVersion": "1.0.0",
-            "name": "netbindingpasst",
+            "name": "primary-udn-kubevirt-binding",


orelmisan · 2025-09-29T12:39:53Z

docs/network/net_binding_plugins/passt.md

 specified in the Kubevirt CR when registering the network binding plugin.

 ### Feature Gate
-If not already set, add the `NetworkBindingPlugins` FG.


This is only relevant for KubeVirt versions < v1.5

general note - i start to wonder if it wouldn't be good to have docs per release via branches

+1 to having a doc per release. I see the doc now has many "version xxx and above/before version xxx"

orelmisan · 2025-09-29T12:40:35Z

docs/network/net_binding_plugins/passt.md


 ### Feature Gate
-If not already set, add the `NetworkBindingPlugins` FG.
+If not already set, add the `PasstIPStackMigration` Feature Gate.


Could you please elaborate why should this FG be set?
Please note that this feature work only with network providers that provide sticky IPs. I would argue that this document should reflect the more common case where sticky IPs aren't necessarily provided.

there is "This Feature gate toggles calling of passt-repair for Passt seamless migration.

but i will remove this change

oshoval · 2025-09-29T13:08:26Z

docs/network/net_binding_plugins/passt.md

 and [here](#passt-sidecar-image).

-When using the plugin, additional memory overhead of `500Mi` will be requested for the compute container in the virt-launcher pod.
+When using the plugin, additional memory overhead of `250Mi` will be requested for the compute container in the virt-launcher pod.


@orelmisan @nirdothan
on which version, the need was reduced to 250Mi ?

If we keep backward support in the document, it becomes important if it started since specific version

on which version, the need was reduced to 250Mi ?

This is a change in passt, not KubeVirt.

This part was changed by #933, please consider rebasing.

oshoval · 2025-09-29T13:11:43Z

thanks, addressed comments

orelmisan · 2025-09-30T12:42:15Z

docs/network/net_binding_plugins/passt.md

-The CNI plugin binary can be retrieved directly from the kubevirt release
-assets (on GitHub) or to be built from its
+
+#### prior to v1.6.0


Please consider moving this section below the 'v1.6-and-above' section. It would be more logical to present the information relevant to the newest version first.

orelmisan · 2025-09-30T12:46:07Z

docs/network/net_binding_plugins/passt.md


-### Feature Gate
-If not already set, add the `NetworkBindingPlugins` FG.
+### Feature Gate - for KubeVirt versions prior to v1.5


Tis part was changed by #933, please consider rebasing.

orelmisan · 2025-09-30T12:46:59Z

docs/network/net_binding_plugins/passt.md

 and [here](#passt-sidecar-image).

-When using the plugin, additional memory overhead of `500Mi` will be requested for the compute container in the virt-launcher pod.
+When using the plugin, additional memory overhead of `250Mi` will be requested for the compute container in the virt-launcher pod.


on which version, the need was reduced to 250Mi ?

This is a change in passt, not KubeVirt.

This part was changed by #933, please consider rebasing.

oshoval · 2025-09-30T12:53:34Z

rebase / addressed comments

frenzyfriday

/lgtm

docs/network/net_binding_plugins/passt.md

frenzyfriday · 2025-10-20T12:25:42Z

/cc @orelmisan for approval

kubevirt-bot · 2025-10-20T12:25:47Z

@frenzyfriday: GitHub didn't allow me to request PR reviews from the following users: for, approval.

Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @orelmisan for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

orelmisan

Thank you for the changes @oshoval.
Just some minor comments.

orelmisan · 2025-10-21T11:20:02Z

docs/network/net_binding_plugins/passt.md

+      annotations:
+        description: passt-binding-cni installs 'passt binding' CNI on cluster nodes
+    spec:
+      priorityClassName: system-cluster-critical


nit: Do we really need to define a high priority class?

on clusters that are on their resource edge, yes
it is a preserved PC, that is higher than user custom PCs
It is what we are doing on CNAO / HCO / Kubevirt on other components, it is fine to keep it

orelmisan · 2025-10-21T11:21:41Z

docs/network/net_binding_plugins/passt.md

 For KubeVirt versions prior to v1.5, make sure to enable the `NetworkBindingPlugins` FG.
 ```
-kubectl patch kubevirts -n kubevirt kubevirt --type=json -p='[{"op": "add", "path": "/spec/configuration/developerConfiguration/featureGates/-",   "value": "NetworkBindingPlugins"}]'
+kubectl patch kubevirt -n kubevirt kubevirt --type=merge -p='{"spec":{"configuration":{"developerConfiguration":{"featureGates":["NetworkBindingPlugins"]}}}}'


Could you please elaborate on the advantages of the proposed approach?

the previous fails if annotation doesnt exist

Which annotation?

not annotation, it doesnt work if this path doesnt exists beforehand /spec/configuration/developerConfiguration/featureGates
while the new one does

if you spin kubevirt and try you will see

orelmisan · 2025-10-21T11:22:53Z

docs/network/net_binding_plugins/passt.md

 > The passt binding is still in evaluation, use it with care.

+**Note**:
+> It is up to the cluster admin to decide if the plugin is to be available in the cluster.


I think that it is implicit since users have to manually deploy it on their clusters.

same text that was before, i just removed the "The specific passt plugin has no FG by its own"
i prefer to not touch it in this PR

I don't see the removal, but this is not a blocker.

hmm it is double there now, will update

orelmisan · 2025-10-21T11:23:47Z

docs/network/net_binding_plugins/passt.md


+**Note**:
+> It is up to the cluster admin to decide if the plugin is to be available in the cluster.
+> The passt binding is still in evaluation, use it with care.


Please consider the following alternative wording:

Suggested change

> The passt binding is still in evaluation, use it with care.

> The passt binding plugin is an alpha feature and may be unstable or subject to breaking changes. Use with caution.

i just changed the place, i prefer to not change it on this PR

I don't see the removal, but this is not a blocker.

#916 (comment)

Update docs about cni daemonSet. Update outdated parts. Signed-off-by: Or Shoval <[email protected]>

oshoval · 2025-10-21T12:07:48Z

removed double text
https://github.com/kubevirt/user-guide/compare/aaf086b010875820fd7e1e06f2ba7d10d3157823..5133e32d92b38b1e0f6ea8a9b56d2a45a83d6d81

orelmisan

Thanks @oshoval
/approve

kubevirt-bot · 2025-10-21T12:20:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orelmisan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~docs/network/OWNERS~~ [orelmisan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot · 2025-10-22T10:59:32Z

/remove-label needs-approver-review

kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Aug 25, 2025

oshoval marked this pull request as ready for review August 28, 2025 11:17

kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2025

kubevirt-bot requested review from RamLavi and ormergi August 28, 2025 11:17

oshoval force-pushed the passt branch from 4da0eb5 to 7c6ab78 Compare September 1, 2025 06:07

kubevirt-bot requested a review from nirdothan September 1, 2025 13:01

aburdenthehand added the sig/network label Sep 10, 2025

nirdothan reviewed Sep 15, 2025

View reviewed changes

oshoval force-pushed the passt branch from 7c6ab78 to c9efb1c Compare September 15, 2025 11:45

nirdothan approved these changes Sep 15, 2025

View reviewed changes

kubevirt-bot assigned nirdothan Sep 15, 2025

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2025

kubevirt-bot added the needs-approver-review Indicates that a PR requires a review from an approver. label Sep 24, 2025

oshoval mentioned this pull request Sep 28, 2025

net, passt: Rm optimization requirements #933

Merged

8 tasks

orelmisan suggested changes Sep 29, 2025

View reviewed changes

kubevirt-bot assigned orelmisan Sep 29, 2025

kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2025

oshoval commented Sep 29, 2025

View reviewed changes

oshoval force-pushed the passt branch from c9efb1c to bab6398 Compare September 29, 2025 13:11

orelmisan suggested changes Sep 30, 2025

View reviewed changes

oshoval force-pushed the passt branch from bab6398 to aaf086b Compare September 30, 2025 12:53

frenzyfriday reviewed Oct 7, 2025

View reviewed changes

docs/network/net_binding_plugins/passt.md Show resolved Hide resolved

kubevirt-bot assigned frenzyfriday Oct 7, 2025

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2025

oshoval requested a review from orelmisan October 15, 2025 06:30

orelmisan reviewed Oct 21, 2025

View reviewed changes

oshoval force-pushed the passt branch from aaf086b to 5133e32 Compare October 21, 2025 12:05

passt: Fix docs

62d8b7d

Update docs about cni daemonSet. Update outdated parts. Signed-off-by: Or Shoval <[email protected]>

kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025

oshoval force-pushed the passt branch from 5133e32 to 62d8b7d Compare October 21, 2025 12:05

orelmisan reviewed Oct 21, 2025

View reviewed changes

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2025

oshoval requested a review from nirdothan October 21, 2025 12:27

nirdothan approved these changes Oct 22, 2025

View reviewed changes

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2025

kubevirt-bot merged commit facca37 into kubevirt:main Oct 22, 2025
6 checks passed

kubevirt-bot removed the needs-approver-review Indicates that a PR requires a review from an approver. label Oct 22, 2025

	> The passt binding is still in evaluation, use it with care.
	> The passt binding plugin is an alpha feature and may be unstable or subject to breaking changes. Use with caution.

passt: Fix docs #916

passt: Fix docs #916

Uh oh!

Conversation

oshoval commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kubevirt-bot commented Aug 25, 2025

Uh oh!

orelmisan commented Sep 1, 2025

Uh oh!

nirdothan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aburdenthehand commented Sep 17, 2025

Uh oh!

oshoval commented Sep 17, 2025

Uh oh!

kubevirt-bot commented Sep 24, 2025

Uh oh!

orelmisan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oshoval Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oshoval Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oshoval commented Sep 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oshoval commented Sep 30, 2025

Uh oh!

frenzyfriday left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

frenzyfriday commented Oct 20, 2025

Uh oh!

kubevirt-bot commented Oct 20, 2025

Uh oh!

orelmisan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oshoval commented Aug 25, 2025 •

edited

Loading

oshoval Sep 29, 2025 •

edited

Loading

oshoval Sep 29, 2025 •

edited

Loading

orelmisan Oct 21, 2025 •

edited

Loading