Move applyStorageProfile constant to API package #3962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
dco-signoff: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
size/M
release-note-none
arnongilboa
reviewed
Dec 1, 2025
pkg/common/common.go
Outdated
Comment on lines
71
to
73
| // Deprecated: Use cdiv1.LabelApplyStorageProfile from containerized-data-importer-api instead. | ||
| // This constant is kept for backwards compatibility and will be removed in a future release. | ||
| PvcApplyStorageProfileLabel = cdiv1.LabelApplyStorageProfile |
Collaborator
There was a problem hiding this comment.
why keep it if all refs are updated?
Collaborator
There was a problem hiding this comment.
Still appears in the commit message and the PR description.
noamasu
force-pushed
the
bugfix/move-applystorageprofile-to-cdi-api
branch
2 times, most recently
from
4f3e82f to
379b3a2
Compare
arnongilboa
reviewed
Dec 2, 2025
|
|
||
| // LabelApplyStorageProfile is a PVC label that tells the CDI mutating webhook to modify the PVC | ||
| // according to the storage profile. When set to "true", the webhook will process the PVC based on | ||
| // its associated StorageProfile (e.g., setting volume mode, access modes, etc.). |
Collaborator
There was a problem hiding this comment.
in the e.g. you may add "minimum supported pvc size", as it's the main motivation for its usage in kubevirt via the api.
kubevirt-bot
added
the
needs-rebase
noamasu
force-pushed
the
bugfix/move-applystorageprofile-to-cdi-api
branch
from
379b3a2 to
63cc5d7
Compare
kubevirt-bot
removed
the
needs-rebase
- Add LabelApplyStorageProfile to containerized-data-importer-api package for external consumer access - Update CDI code to use cdiv1.LabelApplyStorageProfile This enables external projects (e.g., KubeVirt) to import the constant from the API package instead of duplicating it. Signed-off-by: Noam Assouline <[email protected]>
noamasu
force-pushed
the
bugfix/move-applystorageprofile-to-cdi-api
branch
from
63cc5d7 to
36bfa8d
Compare
Collaborator
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving
cdi.kubevirt.io/applyStorageProfileto the API package.What this PR does / why we need it:
This enables external projects (e.g., KubeVirt) to import the constant from the API package instead of duplicating it.
Which issue(s) this PR fixes:
Part of a fix for # https://issues.redhat.com/browse/CNV-73408
This kubevirt/kubevirt#16229 PR in kubevirt relies on this change.
Special notes for your reviewer:
@arnongilboa
@ShellyKa13
Release note: