Skip to content

Conversation

gaohoward
Copy link
Collaborator

User can define an environment variable EXTRA_IMAGES that contains a list of external image urls separated by spaces.

At the end of 'make cluster-up' target the EXTRA_IMAGES are processed by a script ./cluster-up/extra-images.sh so that for each image url, it pulls the image and then push the image into the local registry.

Then when 'make cluster-sync' is invoked, it searches all external image urls in the generated yamls in _out/manifests/ and replaces them with corresponding urls in the local registry (registry:5000)

What this PR does / why we need it:

Added functionality for cluster-up target to allow adding external images to the internal local docker registry

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3801

Special notes for your reviewer:

Release note:

Normal users should not affected by this feature. Only users with isolated environments can use this feature to add
any external images to the local registry. Make sure your local machine have access to the external repositories in order to pull them and push to the local registry.

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jun 26, 2025
@kubevirt-bot
Copy link
Contributor

Hi @gaohoward. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign akalenyu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jun 26, 2025
@gaohoward
Copy link
Collaborator Author

@awels Hi Alex, just updated the branch. Pls take a look and see if it looks better. Thanks!

…rtci cluster (kubevirt#3801)

User can define an environment variable EXTRA_IMAGES that contains a list of
external image urls separated by spaces.

At the end of 'make cluster-up' target the EXTRA_IMAGES are processed
by a script ./cluster-up/extra-images.sh so that for each image url,
it pulls the image and then push the image into the local registry.

Then when 'make cluster-sync' is invoked, it searches all external
image urls in the generated yamls in _out/manifests/ and replaces
them with corresponding urls in the local registry (registry:5000)

Signed-off-by: Howard Gao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support putting external images into the local registry of the kubevirtci cluster

4 participants