Skip to content

Ready case studies shortcode for Docsy #50983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lmktfy
Copy link
Contributor

@lmktfy lmktfy commented May 19, 2025

Revise a shortcode that renders a selection of case studies. Also update the SCSS to make it look about right.

This changes the HTML on the site landing page(s), not the rendering within the Case Studies section.

Here's a preview

Helps with issue #41171
Supersedes PR #48560

/area web-development

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 19, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 19, 2025
Copy link

netlify bot commented May 19, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9c14c37
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68309d685f9c290008898d96
😎 Deploy Preview https://deploy-preview-50983--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmktfy lmktfy force-pushed the 20241027_ready_case_studies_shortcode_docsy branch from db2d75a to 94de6f5 Compare May 19, 2025 20:59
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 19, 2025
@lmktfy lmktfy marked this pull request as ready for review May 19, 2025 20:59
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 19, 2025
@k8s-ci-robot k8s-ci-robot requested a review from natalisucks May 19, 2025 20:59
Copy link
Member

@shurup shurup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I checked how it renders in Firefox and Chrome, and it looks good. I have a couple of minor suggestions for improving CSS for smaller screens.

@lmktfy lmktfy force-pushed the 20241027_ready_case_studies_shortcode_docsy branch from fcf65c0 to ab9c4d1 Compare May 23, 2025 16:07
This changes the HTML on the site landing page(s), not the rendering
within the Case Studies section.

Co-authored-by: Dmitry Shurupov <[email protected]>
@lmktfy lmktfy force-pushed the 20241027_ready_case_studies_shortcode_docsy branch from ab9c4d1 to 9c14c37 Compare May 23, 2025 16:08
@shurup
Copy link
Member

shurup commented May 27, 2025

Thanks, I like everything now and think we can move forward with this!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1bacc67654c1667ce806607a092e7e0c3bcd4191

@katcosgrove
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: katcosgrove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit b8b16de into kubernetes:main May 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants