-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note for TLS settings on default rule #49233
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -519,6 +519,24 @@ section. | |
|
||
{{% code_sample file="service/networking/tls-example-ingress.yaml" %}} | ||
|
||
{{< note >}} | ||
As an alternative to make TLS work on the default rule or when faced with specific | ||
Subject Alternative Name requirements (e.g mandatory IPs instead of FQDN), user can update the | ||
Ingress Controller to set as default certificate a custom Secret that satifies those requirements. | ||
|
||
If using Nginx Ingress: | ||
|
||
kubectl -n ingress-nginx edit deployment ingress-controller | ||
|
||
Edit the args section as follows: | ||
|
||
args: | ||
- /nginx-ingress-controller | ||
- '--publish-service=$(POD_NAMESPACE)/ingress-nginx-controller' | ||
- '--default-ssl-certificate=default/testsecret-tls' | ||
- ... | ||
{{< /note >}} | ||
|
||
{{< note >}} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This note is useful, though - it's telling people to go and read the docs for the ingress controller(s) that they are actually using. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The intent is to rectify or complete the note before it. See capture below.
|
||
There is a gap between TLS features supported by various Ingress | ||
controllers. Please refer to documentation on | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This advice is specific to one ingress controller. We could add it as part of a blog article or a tutorial, but I don't think it's right for a page about the Ingress API as a concept.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would agree with that indeed