Add [email protected] to testgrid-alert-email for master-blocking and master-informing jobs #34548

Vyom-Yadav · 2025-03-19T14:41:39Z

Adds [email protected] to all jobs which have testgrid-dashboards: .*sig-release-master-(informing|blocking).*

Vyom-Yadav · 2025-03-19T15:01:11Z

I'll update the generate conf for dra.

SergeyKanzhelev · 2025-03-19T17:11:14Z

looks good for sig node. Maybe sig testing representative can approve globally.

BenTheElder · 2025-03-20T23:55:08Z

looks good for sig node. Maybe sig testing representative can approve globally.

yeah
/assign

is there any context / discussion / sig release approval we can point to?

Vyom-Yadav · 2025-03-23T13:54:16Z

is there any context / discussion / sig release approval we can point to?

Yeah, this has been a longstanding item. It has been mentioned in the previous retros:

CC'ing the current RT lead and Release Signal Lead

/cc @npolshakova @wendy-ha18

BenTheElder · 2025-03-24T18:08:55Z

/approve

BenTheElder · 2025-03-24T18:10:08Z

config/jobs/image-pushing/releng/k8s-staging-artifact-promoter.yaml

@@ -4,7 +4,7 @@ postsubmits:
      cluster: k8s-infra-prow-build-trusted
      annotations:
        testgrid-dashboards: sig-release-releng-blocking, sig-release-master-informing, sig-release-image-pushes, sig-k8s-infra-gcb


this should probably be a follow-up, but I'm not convinced this should be in release-master-informing? it's not testing kubernetes. (vs sig-release-releng-blocking, that makes sense)

(same for ~all of image-pushing/)

I'll open a thread in #sig-release

Opened https://kubernetes.slack.com/archives/C2C40FMNF/p1748076703194349

dims · 2025-04-29T18:40:46Z

/lgtm

k8s-triage-robot · 2025-04-29T21:07:47Z

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

The PR does have any do-not-merge/* labels
The PR does not have the needs-ok-to-test label
The PR is mergeable (does not have a needs-rebase label)
The PR is approved (has cncf-cla: yes, lgtm, approved labels)
The PR is failing tests required for merge

You can:

Review the full test history for this PR
Prevent this bot from retesting with /lgtm cancel or /hold
Help make our tests less flaky by following our Flaky Tests Guide

/retest

k8s-triage-robot · 2025-04-29T23:34:47Z

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

The PR does have any do-not-merge/* labels
The PR does not have the needs-ok-to-test label
The PR is mergeable (does not have a needs-rebase label)
The PR is approved (has cncf-cla: yes, lgtm, approved labels)
The PR is failing tests required for merge

You can:

Review the full test history for this PR
Prevent this bot from retesting with /lgtm cancel or /hold
Help make our tests less flaky by following our Flaky Tests Guide

/retest

k8s-triage-robot · 2025-04-30T02:01:47Z

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

The PR does have any do-not-merge/* labels
The PR does not have the needs-ok-to-test label
The PR is mergeable (does not have a needs-rebase label)
The PR is approved (has cncf-cla: yes, lgtm, approved labels)
The PR is failing tests required for merge

You can:

Review the full test history for this PR
Prevent this bot from retesting with /lgtm cancel or /hold
Help make our tests less flaky by following our Flaky Tests Guide

/retest

k8s-triage-robot · 2025-04-30T04:24:47Z

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

The PR does have any do-not-merge/* labels
The PR does not have the needs-ok-to-test label
The PR is mergeable (does not have a needs-rebase label)
The PR is approved (has cncf-cla: yes, lgtm, approved labels)
The PR is failing tests required for merge

You can:

Review the full test history for this PR
Prevent this bot from retesting with /lgtm cancel or /hold
Help make our tests less flaky by following our Flaky Tests Guide

/retest

k8s-triage-robot · 2025-04-30T06:44:47Z

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

The PR does have any do-not-merge/* labels
The PR does not have the needs-ok-to-test label
The PR is mergeable (does not have a needs-rebase label)
The PR is approved (has cncf-cla: yes, lgtm, approved labels)
The PR is failing tests required for merge

You can:

Review the full test history for this PR
Prevent this bot from retesting with /lgtm cancel or /hold
Help make our tests less flaky by following our Flaky Tests Guide

/retest

k8s-triage-robot · 2025-04-30T09:04:48Z

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

The PR does have any do-not-merge/* labels
The PR does not have the needs-ok-to-test label
The PR is mergeable (does not have a needs-rebase label)
The PR is approved (has cncf-cla: yes, lgtm, approved labels)
The PR is failing tests required for merge

You can:

Review the full test history for this PR
Prevent this bot from retesting with /lgtm cancel or /hold
Help make our tests less flaky by following our Flaky Tests Guide

/retest

k8s-triage-robot · 2025-04-30T11:24:48Z

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

The PR does have any do-not-merge/* labels
The PR does not have the needs-ok-to-test label
The PR is mergeable (does not have a needs-rebase label)
The PR is approved (has cncf-cla: yes, lgtm, approved labels)
The PR is failing tests required for merge

You can:

Review the full test history for this PR
Prevent this bot from retesting with /lgtm cancel or /hold
Help make our tests less flaky by following our Flaky Tests Guide

/retest

k8s-triage-robot · 2025-04-30T13:48:48Z

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

The PR does have any do-not-merge/* labels
The PR does not have the needs-ok-to-test label
The PR is mergeable (does not have a needs-rebase label)
The PR is approved (has cncf-cla: yes, lgtm, approved labels)
The PR is failing tests required for merge

You can:

Review the full test history for this PR
Prevent this bot from retesting with /lgtm cancel or /hold
Help make our tests less flaky by following our Flaky Tests Guide

/retest

wendy-ha18 · 2025-04-30T14:24:52Z

/hold

Signed-off-by: Vyom-Yadav <[email protected]>

dims · 2025-05-26T12:31:07Z

/approve
/lgtm

please remove /hold when appropriate

k8s-ci-robot · 2025-05-26T12:31:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, Vyom-Yadav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~config/OWNERS~~ [BenTheElder,dims]
~~config/jobs/image-pushing/releng/OWNERS~~ [BenTheElder,dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Vyom-Yadav · 2025-05-26T12:37:15Z

/unhold

k8s-ci-robot · 2025-05-26T12:50:31Z

@Vyom-Yadav: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

key k8s-staging-artifact-promoter.yaml using file config/jobs/image-pushing/releng/k8s-staging-artifact-promoter.yaml
key k8s-staging-build-image.yaml using file config/jobs/image-pushing/releng/k8s-staging-build-image.yaml
key k8s-staging-kubernetes.yaml using file config/jobs/image-pushing/releng/k8s-staging-kubernetes.yaml
key release-master-windows.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-master-windows.yaml
key sig-auth-encryption-at-rest.yaml using file config/jobs/kubernetes/sig-auth/sig-auth-encryption-at-rest.yaml
key ec2-e2e.yaml using file config/jobs/kubernetes/sig-cloud-provider/aws/ec2-e2e.yaml
key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml
key gpu-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gpu/gpu-gce.yaml
key sig-network-gce.yaml using file config/jobs/kubernetes/sig-network/sig-network-gce.yaml
key crio.yaml using file config/jobs/kubernetes/sig-node/crio.yaml
key dra-ci.yaml using file config/jobs/kubernetes/sig-node/dra-ci.yaml
key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml
key sig-scalability-periodic-ec2.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-periodic-ec2.yaml
key sig-scalability-release-blocking-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-release-blocking-jobs.yaml
key kubernetes-kind.yaml using file config/jobs/kubernetes/sig-testing/kubernetes-kind.yaml
key make-test.yaml using file config/jobs/kubernetes/sig-testing/make-test.yaml
key verify.yaml using file config/jobs/kubernetes/sig-testing/verify.yaml

In response to this:

Adds [email protected] to all jobs which have testgrid-dashboards: .*sig-release-master-(informing|blocking).*

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 19, 2025

k8s-ci-robot requested review from andrewsykim and aravindhp March 19, 2025 14:41

github-project-automation bot added this to SIG Node CI/Test Board Mar 19, 2025

k8s-ci-robot added the sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. label Mar 19, 2025

github-project-automation bot moved this to Triage in SIG Node CI/Test Board Mar 19, 2025

k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Mar 19, 2025

SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Mar 19, 2025

enj added this to SIG Auth Mar 20, 2025

github-project-automation bot moved this to Needs Triage in SIG Auth Mar 20, 2025

k8s-ci-robot assigned BenTheElder Mar 20, 2025

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2025

Vyom-Yadav force-pushed the add-release-team-to-alert-emails branch from 682521d to 5cd3d50 Compare March 23, 2025 13:49

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 23, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2025

BenTheElder reviewed Mar 24, 2025

View reviewed changes

benjaminapetersen moved this from Needs Triage to !SIG Auth in SIG Auth Apr 28, 2025

k8s-ci-robot assigned dims Apr 29, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2025

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2025

Vyom-Yadav added 2 commits May 24, 2025 13:58

Add [email protected] to sig-release-master-blocking jobs

09ca59c

Signed-off-by: Vyom-Yadav <[email protected]>

Add [email protected] to sig-release-master-informing jobs

ce3f0c6

Signed-off-by: Vyom-Yadav <[email protected]>

Vyom-Yadav force-pushed the add-release-team-to-alert-emails branch from 5cd3d50 to ce3f0c6 Compare May 24, 2025 08:32

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2025

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2025

k8s-ci-robot merged commit b863e28 into kubernetes:master May 26, 2025
6 of 7 checks passed

github-project-automation bot moved this from !SIG Auth to Closed / Done in SIG Auth May 26, 2025

Rajalakshmi-Girish mentioned this pull request May 28, 2025

Remove Image push jobs from sig-release-master-informing #34868

Merged

Add [email protected] to testgrid-alert-email for master-blocking and master-informing jobs #34548

Add [email protected] to testgrid-alert-email for master-blocking and master-informing jobs #34548

Conversation

Vyom-Yadav commented Mar 19, 2025

Uh oh!

Vyom-Yadav commented Mar 19, 2025

Uh oh!

SergeyKanzhelev commented Mar 19, 2025

Uh oh!

BenTheElder commented Mar 20, 2025

Uh oh!

Vyom-Yadav commented Mar 23, 2025

Uh oh!

BenTheElder commented Mar 24, 2025

Uh oh!

BenTheElder Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BenTheElder Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

Vyom-Yadav Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

Vyom-Yadav May 24, 2025

Choose a reason for hiding this comment

Uh oh!

dims commented Apr 29, 2025

Uh oh!

k8s-triage-robot commented Apr 29, 2025

Uh oh!

k8s-triage-robot commented Apr 29, 2025

Uh oh!

k8s-triage-robot commented Apr 30, 2025

Uh oh!

k8s-triage-robot commented Apr 30, 2025

Uh oh!

k8s-triage-robot commented Apr 30, 2025

Uh oh!

k8s-triage-robot commented Apr 30, 2025

Uh oh!

k8s-triage-robot commented Apr 30, 2025

Uh oh!

k8s-triage-robot commented Apr 30, 2025

Uh oh!

wendy-ha18 commented Apr 30, 2025

Uh oh!

dims commented May 26, 2025

Uh oh!

k8s-ci-robot commented May 26, 2025

Uh oh!

Vyom-Yadav commented May 26, 2025

Uh oh!

Uh oh!

k8s-ci-robot commented May 26, 2025

Uh oh!

Uh oh!

BenTheElder Mar 24, 2025 •

edited

Loading