Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dra uses --ginkgo-flags #33948

Merged
merged 3 commits into from
Dec 29, 2024
Merged

dra uses --ginkgo-flags #33948

merged 3 commits into from
Dec 29, 2024
+2 −1

Conversation

elieser1101
Copy link
Contributor

@elieser1101 elieser1101 commented Dec 13, 2024 •
edited
Loading

We should be able to pass the --label-filter to ginkgo as the non kubetest2 job does.

These jobs are not working at the moment. they succeed but skips all the tests.

https://testgrid.k8s.io/sig-node-cri-o#pr-node-kubelet-crio-cgrpv1-dra-kubetest2
https://testgrid.k8s.io/sig-node-cri-o#pr-node-kubelet-crio-cgrpv2-dra-kubetest2

Need these other 2 PRs to get going before thtis is available
kubernetes/kubernetes#129215 - test-e2e-node.sh to get the LABEL_FILTER var
kubernetes-sigs/kubetest2#286 - kubetest2 enable --label-filter

relates to: #32567
cc: @pohly @bart0sh

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @elieser1101. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 13, 2024
@elieser1101 elieser1101 mentioned this pull request Dec 13, 2024
Merged
pohly
pohly reviewed Dec 14, 2024
View reviewed changes
config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml
@@ -4361,7 +4361,8 @@ presubmits:
- --repo-root=.
- --gcp-zone=us-west1-b
- --parallelism=1
- '--test-args=--ginkgo.timeout=1h --ginkgo.label-filter="Feature: containsAny DynamicResourceAllocation && Feature: isSubsetOf DynamicResourceAllocation && !Flaky && !Slow" --feature-gates="DynamicResourceAllocation=true" --service-feature-gates="DynamicResourceAllocation=true" --runtime-config=api/alpha=true,api/beta=true --container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}"'
- '--ginkgo-flags="--timeout=1h --label-filter="Feature: containsAny DynamicResourceAllocation && Feature: isSubsetOf DynamicResourceAllocation && !Flaky && !Slow"'
- '--test-args=--feature-gates="DynamicResourceAllocation=true" --service-feature-gates="DynamicResourceAllocation=true" --runtime-config=api/alpha=true,api/beta=true --container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}"'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's address https://github.com/kubernetes-sigs/kubetest2/pull/286/files#r1884992400 first, then update both dra-kubetest2 jobs accordingly.

@kannon92
Copy link
Contributor

/ok-to-test
/hold

https://github.com/kubernetes/test-infra/pull/33948/files#r1884994077

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 20, 2024
@elieser1101
Copy link
Contributor Author

dependencies are already in place for this to work
@kannon92 @pohly

pohly
pohly approved these changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

We can merge this now, but beware that it will have to be re-done on top of #34010

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2024
kannon92
kannon92 approved these changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elieser1101, kannon92, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2024
@elieser1101
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5dc092c into kubernetes:master Dec 29, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@elieser1101: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

We should be able to pass the --label-filter to ginkgo as the non kubetest2 job does.

These jobs are not working at the moment. they succeed but skips all the tests.

https://testgrid.k8s.io/sig-node-cri-o#pr-node-kubelet-crio-cgrpv1-dra-kubetest2
https://testgrid.k8s.io/sig-node-cri-o#pr-node-kubelet-crio-cgrpv2-dra-kubetest2

Need these other 2 PRs to get going before thtis is available
kubernetes/kubernetes#129215 - test-e2e-node.sh to get the LABEL_FILTER var
kubernetes-sigs/kubetest2#286 - kubetest2 enable --label-filter

relates to: #32567
cc: @pohly @bart0sh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pohly
Copy link
Contributor

pohly commented Dec 30, 2024

Was this updated job tested somewhere?

@elieser1101
Copy link
Contributor Author

Yeah I tested it but is failing, I think the flag is getting double quoted

Ginkgo Flags: -timeout=24h -skip="\[Flaky\]|\[Slow\]|\[Serial\]"  --label-filter=""Feature: containsAny DynamicResourceAllocation && Feature: isSubsetOf DynamicResourceAllocation && !Flaky && !Slow""

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/128092/pull-kubernetes-node-e2e-crio-cgrpv1-dra-kubetest2/1873442305080299520
Is not picking any test

ginkgo run failed
  Found no test suites

@pohly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 approved these changes

@pohly pohly pohly approved these changes

@endocrimes endocrimes Awaiting requested review from endocrimes

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@pohly pohly

@kannon92 kannon92

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elieser1101 @k8s-ci-robot @kannon92 @pohly