Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable PVs for pre-submit kubemark jobs #16981

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Disable PVs for pre-submit kubemark jobs #16981

merged 1 commit into from
Mar 27, 2020

Conversation

maniSbindra
Copy link
Contributor

Currently PVs do not work on kube mark clusters due to reasons mentioned in the issue kubernetes/perf-tests#803.

This change disables PVs for pre-submit kubemark jobs. Please see conversation around this in the PR kubernetes/perf-tests#1125 (comment).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 27, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @maniSbindra. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 27, 2020
@k8s-ci-robot k8s-ci-robot requested review from mborsz and mm4tt March 27, 2020 12:00
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 27, 2020
mm4tt
mm4tt reviewed Mar 27, 2020
View reviewed changes
Copy link
Contributor

@mm4tt mm4tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

config/jobs/kubernetes/sig-scalability/sig-scalability-presubmit-jobs.yaml Outdated
@@ -223,6 +223,7 @@ presubmits:
- --test-cmd-args=--testoverrides=./testing/load/experimental/overrides/enable_jobs.yaml
# TODO(https://github.com/kubernetes/perf-tests/issues/803): Re-enable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove these two commented lines. Here and below

config/jobs/kubernetes/sig-scalability/sig-scalability-presubmit-jobs.yaml Outdated Show resolved Hide resolved
mm4tt
mm4tt reviewed Mar 27, 2020
View reviewed changes
config/jobs/kubernetes/sig-scalability/sig-scalability-presubmit-jobs.yaml
@@ -211,6 +211,7 @@ presubmits:
- --test-cmd-args=cluster-loader2
- --test-cmd-args=--nodes=500
- --test-cmd-args=--provider=kubemark
- --env=CL2_ENABLE_PVS=false # TODO(https://github.com/kubernetes/perf-tests/issues/803): Fix me
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it might have been not clear. Now we have this env, let's delete the lines 225, 226, 419,420.

        # TODO(https://github.com/kubernetes/perf-tests/issues/803): Re-enable
        # - --test-cmd-args=--testoverrides=./testing/load/experimental/overrides/enable_pvs.yaml

They are redundant.

Also, coud you squash the commits into one? Thanks!

@mm4tt
Copy link
Contributor

mm4tt commented Mar 27, 2020

This is good, but please squash all the commits into one

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 27, 2020
@maniSbindra maniSbindra force-pushed the disable-PVs-for-presubmit-kubemark-jobs branch from 00b346a to 9f84783 Compare March 27, 2020 12:45
@maniSbindra
Copy link
Contributor Author

Thanks @mm4tt I have squashed changes into a single commit.

@mm4tt
Copy link
Contributor

mm4tt commented Mar 27, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maniSbindra, mm4tt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit 48de1fc into kubernetes:master Mar 27, 2020
@k8s-ci-robot
Copy link
Contributor

@maniSbindra: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key sig-scalability-presubmit-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-presubmit-jobs.yaml

In response to this:

Currently PVs do not work on kube mark clusters due to reasons mentioned in the issue kubernetes/perf-tests#803.

This change disables PVs for pre-submit kubemark jobs. Please see conversation around this in the PR kubernetes/perf-tests#1125 (comment).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm4tt mm4tt mm4tt left review comments

@mborsz mborsz Awaiting requested review from mborsz

Assignees

@mm4tt mm4tt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maniSbindra @k8s-ci-robot @mm4tt