Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create 1.33 release directory #2706
base: master
Are you sure you want to change the base?
Create 1.33 release directory #2706
Changes from 1 commit
3ab1e96
ec11d8c
af19a15
6448191
70f1e66
b00ed62
5462dd4
a2b07bb
86947d8
c6fb0f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks at least 1 week too early. It gives us only 3 weeks for code/test. We need at least 4 weeks, which is what we had in 1.32 and that was actually the shortest code+test we had in the last 12 releases...
See https://docs.google.com/spreadsheets/d/1r7nv5qeSPbU2OieEht6U1it5m4QeS3Iv7a83ujbs7kU/edit?resourcekey=0-vc4oKe2uijpmpoeyjgRfEQ&gid=0#gid=0
@liggitt @thockin @deads2k @soltysh @wojtek-t
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it should be 3/20.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it feels very rushed - we have a 3 month cycle and 1/4 of it is development.
That said...
This timeline indicates that the cycle begins Jan 13. But really, it began the moment the tree unfroze. So we have (had) a lot more than just 3 weeks for dev. But the holidays ate all of December, so in PRACTICE, not really.
I don't know how to break the cycle. Every cycle it feels like it gets shorter and less dev-time, then we all argue about it and then we extend it. Can we make it policy to have no less than 4 for dev?
During the March 6-25 window, why can't we continue to allow development, perhaps with the bar higher, but not as high as the final stabilization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely agree wrt making a strict policy for 4 dev weeks after the enhancement freeze.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at least 4 weeks...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree- I think Week 10 code freeze will give people more time. @katcosgrove would this work with the docs deadlines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with pushing code freeze to week 10. Week 11 is too close to Docs Freeze, considering SIGs already struggle to meet documentation deadlines. I am unwilling to increase pressure on Release Docs and SIG Docs by shortening that timeline even further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so that is the Thursday of Week 10, which starts on 3/24 based on @soltysh's calculations? In other words, 3/27?
Or did you mean 3/20 @katcosgrove ? It seems the math was wrong at some point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant week 10, 3/20. I think the dates and week mappings are fixed here now: https://github.com/kubernetes/sig-release/blob/86947d89fc9958baecf88c66c2336fb3f51b4ab7/releases/release-1.33/README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also updated docs freeze back to week 13: c6fb0f3 @katcosgrove @chanieljdan @rayandas let me know what you think of the deadlines for the last couple weeks!