Skip to content

[WIP] Add bookworm linux/ppc64le variant to kube-cross #3941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[WIP] Add bookworm linux/ppc64le variant to kube-cross #3941

wants to merge 1 commit into from

Conversation

Rajalakshmi-Girish
Copy link
Contributor

This change is to add a Variant to kube-cross image that builds for linux/ppc64le using Debian bookworm.

This is as part of the "ppc64le" (IBM Power) infrastructure onboarding to k8s community.
Ref: https://kubernetes.slack.com/archives/CCK68P2Q2/p1739359083466129

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 27, 2025
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2025
@Rajalakshmi-Girish
Copy link
Contributor Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 27, 2025
@Rajalakshmi-Girish Rajalakshmi-Girish marked this pull request as draft February 27, 2025 15:38
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2025
@Rajalakshmi-Girish Rajalakshmi-Girish changed the title Add bookworm linux/ppc64le variant to kube-cross [WIP] Add bookworm linux/ppc64le variant to kube-cross Feb 27, 2025
@Rajalakshmi-Girish Rajalakshmi-Girish force-pushed the kube-cross-ppc64le branch 4 times, most recently from 61653df to 18b9f3d Compare February 27, 2025 16:51
@Rajalakshmi-Girish Rajalakshmi-Girish changed the title [WIP] Add bookworm linux/ppc64le variant to kube-cross Add bookworm linux/ppc64le variant to kube-cross Feb 27, 2025
@Rajalakshmi-Girish Rajalakshmi-Girish marked this pull request as ready for review February 27, 2025 18:36
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2025
@Rajalakshmi-Girish
Copy link
Contributor Author

@upodroid Can you please take a look at change?

@BenTheElder
Copy link
Member

Hmm, it's suggesting me as a build maintainer (#3941 (comment)) but I'm not comfortable merging this without a broader discussion, cc @kubernetes/release-engineering

This is as part of the "ppc64le" (IBM Power) infrastructure onboarding to k8s community.
Ref: https://kubernetes.slack.com/archives/CCK68P2Q2/p1739359083466129

This isn't strictly part of setting up accounts under SIG K8s Infra and needs the input of SIG Release. Has this been discussed, other than in SIG K8s Infra? As a SIG K8s Infra TL: this is not a decision SIG K8s Infra can make. And prior discussion in SIG Release didn't align with this, AFAIK.

cc @kubernetes/sig-release

@BenTheElder
Copy link
Member

Discussion aside, the build seems to be failing currently https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/release/3941/pull-release-image-kube-cross/1895181260863574016

@Rajalakshmi-Girish
Copy link
Contributor Author

Discussion aside, the build seems to be failing currently https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/release/3941/pull-release-image-kube-cross/1895181260863574016

Yes, I am looking at it. I see below error:

BUILD FAILURE: Build step failure: Image(s) gcr.io/k8s-staging-releng-test/kube-cross-amd64:v1.33.0-go1.23.6-bookworm.0,gcr.io/k8s-staging-releng-test/kube-cross-amd64:v20250227-v0.18.0-12-gc40659f7-go1.23-bookworm-default,gcr.io/k8s-staging-releng-test/kube-cross-amd64:latest-go1.23-bookworm-default could not be found. Check if image(s) exists in the repository.
ERROR: (gcloud.builds.submit) build 8d13fa2e-b5df-429e-a043-12f04e1efabc completed with status "FAILURE"

@Rajalakshmi-Girish Rajalakshmi-Girish marked this pull request as draft February 28, 2025 06:11
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2025
@Rajalakshmi-Girish Rajalakshmi-Girish changed the title Add bookworm linux/ppc64le variant to kube-cross [WIP] Add bookworm linux/ppc64le variant to kube-cross Feb 28, 2025
cpanato
cpanato requested changes Feb 28, 2025
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

cc @saschagrunert @kubernetes/release-managers

images/build/cross/variants.yaml
@@ -17,6 +18,17 @@ variants:
GO_MAJOR_VERSION: '1.23'
OS_CODENAME: 'bullseye'
REVISION: '0'
PLATFORMS: 'linux/amd64 linux/arm64'
v1.33-go1.23-bookworm:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are not using bookworm right now for cross because it have a newer libc that conflict with the kubelet or something, dont remember exactly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @cpanato, you're right! We made this decision because the kubelet binary is not statically linked.

This new variant is being introduced to enable building and testing Kubernetes on the ppc64le architecture with the new infrastructure.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Rajalakshmi-Girish
Once this PR has been reviewed and has the lgtm label, please ask for approval from cpanato. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Rajalakshmi-Girish Rajalakshmi-Girish force-pushed the kube-cross-ppc64le branch 5 times, most recently from 0d7bce7 to a4f282a Compare February 28, 2025 11:13
@Rajalakshmi-Girish
Copy link
Contributor Author

/test pull-release-image-kube-cross

@Rajalakshmi-Girish
Copy link
Contributor Author

/test pull-release-image-kube-cross

@Rajalakshmi-Girish
Copy link
Contributor Author

/test pull-release-image-kube-cross

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato requested changes

@jrsapi jrsapi Awaiting requested review from jrsapi

@salaxander salaxander Awaiting requested review from salaxander

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@cpanato cpanato

Labels
area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rajalakshmi-Girish @BenTheElder @k8s-ci-robot @cpanato