Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert go 1.23 changes to fix pull-release-image-k8s-ci-builder #3781

Merged
merged 2 commits into from
Oct 10, 2024
Merged

revert go 1.23 changes to fix pull-release-image-k8s-ci-builder #3781

merged 2 commits into from
Oct 10, 2024

Conversation

haitch
Copy link
Contributor

@haitch haitch commented Oct 4, 2024 •
edited
Loading

What type of PR is this?

/kind regression

What this PR does / why we need it:

this pipeline breaks pull-release-image-k8s-ci-builder , there are still go1.22 stack required, but when go.mod is based on go1.23, things break.

2 PRs caused the break:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 4, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Oct 4, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @haitch. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 4, 2024
@cpanato
Copy link
Member

cpanato commented Oct 7, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 7, 2024
@cpanato
Copy link
Member

cpanato commented Oct 7, 2024

@haitch can you add the PR that those changes got in?

@haitch
Copy link
Contributor Author

haitch commented Oct 7, 2024

#3759 Bump the all group with 2 updates
#3757 Switch to go 1.23

cpanato
cpanato reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @saschagrunert

@cpanato
Copy link
Member

cpanato commented Oct 8, 2024

/test ls

@k8s-ci-robot
Copy link
Contributor

@cpanato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-release-cluster-up
  • /test pull-release-image-debian-base
  • /test pull-release-image-distroless-iptables
  • /test pull-release-image-go-runner
  • /test pull-release-image-k8s-ci-builder
  • /test pull-release-image-k8s-cloud-builder
  • /test pull-release-image-kube-cross
  • /test pull-release-image-releng-ci
  • /test pull-release-image-setcap
  • /test pull-release-integration-test
  • /test pull-release-test
  • /test pull-release-verify

The following commands are available to trigger optional jobs:

  • /test pull-release-cluster-up-canary
  • /test pull-release-test-canary

Use /test all to run the following jobs that were automatically triggered:

  • pull-release-integration-test
  • pull-release-test
  • pull-release-verify

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cpanato
Copy link
Member

cpanato commented Oct 8, 2024

/test pull-release-image-k8s-ci-builder

saschagrunert
saschagrunert requested changes Oct 9, 2024
View reviewed changes
go.mod Show resolved Hide resolved
@haitch haitch force-pushed the haitao/revert_go123 branch from a3777e1 to ff21415 Compare October 10, 2024 06:05
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 10, 2024
@haitch
Copy link
Contributor Author

haitch commented Oct 10, 2024

/test pull-release-image-k8s-ci-builder

@haitch haitch force-pushed the haitao/revert_go123 branch from ff21415 to f9d22ac Compare October 10, 2024 06:08
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2024
@haitch
Copy link
Contributor Author

haitch commented Oct 10, 2024

/test pull-release-image-k8s-ci-builder

haitch added 2 commits October 10, 2024 00:19
@haitch
Revert "Merge pull request kubernetes#3757 from saschagrunert/go-1.23"
bee2749 
This reverts commit efc04ec, reversing
changes made to 95e5165.
@haitch
revert module bump
d01f6d8 
- maxbrunsfeld/counterfeiter to v6.9.0
- sigs.k8s.io/release-utils to v0.8.4
@haitch haitch force-pushed the haitao/revert_go123 branch from f9d22ac to d01f6d8 Compare October 10, 2024 07:21
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 10, 2024
@haitch
Copy link
Contributor Author

haitch commented Oct 10, 2024

/test pull-release-image-k8s-ci-builder

@saschagrunert saschagrunert mentioned this pull request Oct 10, 2024
Closed
cpanato
cpanato approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will follow up after this to update a few parts

/approve
/lgtm

/hold to defer final approval to @saschagrunert

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2024
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 10, 2024
@saschagrunert
Copy link
Member

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, haitch, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6a34e81 into kubernetes:master Oct 10, 2024
12 checks passed
@saschagrunert saschagrunert mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@jrsapi jrsapi Awaiting requested review from jrsapi

@salaxander salaxander Awaiting requested review from salaxander

Assignees

@saschagrunert saschagrunert

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haitch @k8s-ci-robot @cpanato @saschagrunert