Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k8s-cloud-builder and k8s-ci-builder to Go 1.22.7/1.23.1 #3777

Closed
wants to merge 2 commits into from
Closed

Update k8s-cloud-builder and k8s-ci-builder to Go 1.22.7/1.23.1 #3777

wants to merge 2 commits into from

Conversation

haitch
Copy link
Contributor

@haitch haitch commented Oct 3, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update k8s-cloud-builder and k8s-ci-builder to Go 1.22.7/1.23.1

Which issue(s) this PR fixes:

xref #3738

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Update k8s-cloud-builder and k8s-ci-builder to Go 1.22.7/1.23.1

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Oct 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haitch
Once this PR has been reviewed and has the lgtm label, please assign saschagrunert for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Oct 3, 2024
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 3, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @haitch. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 3, 2024
haitch
haitch commented Oct 3, 2024
View reviewed changes
images/k8s-cloud-builder/variants.yaml
v1.31-cross1.23-bullseye:
CONFIG: 'cross1.23'
KUBE_CROSS_VERSION: 'v1.31.0-go1.23.0-bullseye.0'
KUBE_CROSS_VERSION: 'v1.31.0-go1.23.1-bullseye.0'
# TODO: remove this after upgrade to Go 1.23 is finalized and there's on risk of reverting
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when shall we remove this? from release notes, 1.31.1 is still build with go 1.22.6, I think it's not finalized yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpanato @xmudrii

@haitch
Copy link
Contributor Author

haitch commented Oct 3, 2024

also the 4 release branch PR haven't finish yet, would that block this one?

kubernetes/kubernetes#127600 1.31
kubernetes/kubernetes#127603 1.30
kubernetes/kubernetes#127604 1.29
kubernetes/kubernetes#127605 1.28

@cpanato
Copy link
Member

cpanato commented Oct 3, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2024
@jeremyrickard
Copy link
Contributor

Is this missing the Makefile update @cpanato? I believe the Go version should be updated inimages/releng/k8s-ci-builder/Makefile

@cpanato
Copy link
Member

cpanato commented Oct 3, 2024

Is this missing the Makefile update @cpanato? I believe the Go version should be updated inimages/releng/k8s-ci-builder/Makefile

that as well

@cpanato
Copy link
Member

cpanato commented Oct 3, 2024

but that should not be a blocker

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 3, 2024
@cpanato
Copy link
Member

cpanato commented Oct 3, 2024

the hold was more to have the k/k prs merged

@haitch
Copy link
Contributor Author

haitch commented Oct 4, 2024

/test pull-release-image-k8s-ci-builder

1 similar comment
@haitch
Copy link
Contributor Author

haitch commented Oct 4, 2024

/test pull-release-image-k8s-ci-builder

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 4, 2024
@haitch haitch force-pushed the haitao/newer_go_cloud_ci_builder branch from c92a572 to 4626c78 Compare October 10, 2024 20:13
@k8s-ci-robot k8s-ci-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 10, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 10, 2024
@haitch
Copy link
Contributor Author

haitch commented Oct 10, 2024

/test pull-release-image-k8s-cloud-builder

@haitch
Copy link
Contributor Author

haitch commented Oct 15, 2024

close, now #3778 is unblocked.

@haitch haitch closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimangel jimangel Awaiting requested review from jimangel

@salaxander salaxander Awaiting requested review from salaxander

Assignees
No one assigned
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haitch @k8s-ci-robot @cpanato @jeremyrickard