-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source GOPATH
from go env
in compile-release-tool script
#3560
Source GOPATH
from go env
in compile-release-tool script
#3560
Conversation
Hi @embik. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Signed-off-by: Marvin Beckers <[email protected]>
9a36736
to
0c16084
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This is a very minor chore I stumbled over while working on #3559 - when
GOPATH
isn't set in your environment (and these days, it's not necessary anymore to have it set),make release-tools
fails withThis sources the variable from
go env
, which prints either the set environment variable or the implied default.Feel free to close this if it's not really something you want to merge.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?