Merge pull request #3508 from saschagrunert/release-notes-maps-exclusion

Fix panic when the `--maps-from` value is smaller than 5 characters
kubernetes · Mar 13, 2024 · 9d09f87 · 9d09f87
2 parents 18f8bb3 + 6ef5504
commit 9d09f87
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/pkg/notes/document/document.go b/pkg/notes/document/document.go
@@ -307,7 +307,7 @@ func New(
 		}
 
 		if note.DoNotPublish {
-			logrus.Debugf("skipping PR %d as (marked to not be published)", pr)
+			logrus.Debugf("Skipping PR %d as (marked to not be published)", pr)
 			continue
 		}
 

diff --git a/pkg/notes/notes.go b/pkg/notes/notes.go
@@ -254,7 +254,7 @@ func GatherReleaseNotes(opts *options.Options) (*ReleaseNotes, error) {
 	if err != nil {
 		return nil, fmt.Errorf("listing release notes: %w", err)
 	}
-	logrus.Infof("finished gathering release notes in %v", time.Since(startTime))
+	logrus.Infof("Finished gathering release notes in %v", time.Since(startTime))
 
 	return releaseNotes, nil
 }

diff --git a/pkg/notes/notes_map.go b/pkg/notes/notes_map.go
@@ -37,7 +37,7 @@ type MapProvider interface {
 // NewProviderFromInitString creates a new map provider from an initialization string
 func NewProviderFromInitString(initString string) (MapProvider, error) {
 	// If init string starts with gs:// return a CloudStorageProvider
-	if initString[0:5] == object.GcsPrefix {
+	if len(initString) >= 5 && initString[0:5] == object.GcsPrefix {
 		// Currently for illustration purposes
 		return nil, errors.New("CloudStorageProvider is not yet implemented")
 	}