Skip to content

Commit

Permalink
remove blank spaces
Browse files Browse the repository at this point in the history
Signed-off-by: cpanato <[email protected]>
  • Loading branch information
cpanato committed Nov 12, 2024
1 parent ccf37ec commit 731b255
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions images/build/go-runner/README.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# Kubernetes go-runner image

The Kubernetes go-runner image wraps the gcr.io/distroless/static image and provides a go based
binary that can run commands and wrap stdout/stderr etc.
binary that can run commands and wrap stdout/stderr etc.

Why do we need this? Some of our images like kube-apiserver currently use bash for collecting
logs, so we are not able to switch to distroless images directly for these images. The klog's
`--log-file` was supposed to fix this problem, but we ran into trouble in scalability CI jobs
around log rotation and picked this option instead. we essentially publish a multi-arch
around log rotation and picked this option instead. we essentially publish a multi-arch
manifest with support for various platforms. This can be used as a base for other kubernetes
components.

Expand All @@ -15,7 +15,7 @@ For example instead of running kube-apiserver like this:
"/bin/sh",
"-c",
"exec /usr/local/bin/kube-apiserver {{params}} --allow-privileged={{pillar['allow_privileged']}} 1>>/var/log/kube-apiserver.log 2>&1"
```
```

we would use go-runner like so:
```bash
Expand All @@ -25,6 +25,6 @@ we would use go-runner like so:
{{params}}
```

The go-runner would then ensure that we run the `/usr/local/bin/kube-apiserver` with the
specified parameters and redirect stdout ONLY to the log file specified and ensure anything
The go-runner would then ensure that we run the `/usr/local/bin/kube-apiserver` with the
specified parameters and redirect stdout ONLY to the log file specified and ensure anything
logged to stderr also ends up in the log file.

0 comments on commit 731b255

Please sign in to comment.