Skip to content

Not check the existence of the errorLogger and latencyLogger #3846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tanzp01 wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −12
Open

Not check the existence of the errorLogger and latencyLogger #3846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions util-images/probes/pkg/dnspropagation/probe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"errors"
"flag"
"fmt"
"io"
"log/slog"
"math"
"math/rand"
Expand Down Expand Up @@ -79,9 +80,13 @@ func Run() {
}
if *enableErrorLogging {
errorLogger = slog.New(slog.NewJSONHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelError}))
} else {
errorLogger = slog.New(slog.NewJSONHandler(io.Discard, nil))
}
if *enableLatencyLogging {
latencyLogger = slog.New(slog.NewJSONHandler(os.Stdout, &slog.HandlerOptions{Level: slog.LevelInfo}))
} else {
latencyLogger = slog.New(slog.NewJSONHandler(io.Discard, nil))
}
// creates the in-cluster config
kubeConfig, err := rest.InClusterConfig()
Expand Down Expand Up @@ -184,12 +189,10 @@ func runSinglePod(client kubernetes.Interface, url string, podName string, names
lookupErrorLogged = true
errTimestamp := time.Now()
klog.Errorf("DNS lookup error for url %s at %v: %v", url, errTimestamp.Format(time.RFC3339), err)
if errorLogger != nil {
errorLogger.Error("DNS propagation probe failed",
"hostname", url,
"error", err.Error(),
)
}
errorLogger.Error("DNS propagation probe failed",
"hostname", url,
"error", err.Error(),
)
labels := prometheus.Labels{
"namespace": namespace,
"service": *service,
Expand All @@ -208,12 +211,10 @@ func runSinglePod(client kubernetes.Interface, url string, podName string, names
}
duration := endTime.Sub(timestamp)
klog.V(2).Infof("Pod running time fetched for pod %s, timestamp= %v, DNS propagation duration= %v s", url, timestamp, duration)
if latencyLogger != nil {
latencyLogger.Info("DNS propagation latency recorded",
"hostname", url,
"timestamp", time.Now(),
"propagationLatency (s)", duration.Seconds())
}
latencyLogger.Info("DNS propagation latency recorded",
"hostname", url,
"timestamp", time.Now(),
"propagationLatency (s)", duration.Seconds())
return duration
}
}
Expand Down